Move questions to constant

Author: Sascha Brink

index.html

@@ -32,6 +32,7 @@ <h1 class="page-header">JavaScript - Type Coercion Challenge</h1>
 <script src="scripts/controllers/summaryCtrl.js"></script>
 <script src="scripts/filters/evalFilter.js"></script>
 <script src="scripts/services/DataHolderService.js"></script>
+<script src="scripts/config/questions.js"></script>
 <script src="scripts/config/routeConfig.js"></script>
 
 

scripts/config/questions.js

@@ -0,0 +1,42 @@
+angular.module("typeCoercion")
+  .constant("questions", [
+    '1 == 1',     // returns true
+    '"1" == 1',   // returns true ("1" converts to 1)
+    '1 == true',  // returns true
+    '0 == false', // returns true
+    '"" == 0',    // returns true ("" converts to 0)
+    '"  " == 0',  // returns true ("  " converts to 0)
+    '0 == 1',     // returns false
+    '1 == false', // returns false
+    '0 == true',  // returns false
+    '0 != false', // returns false
+    '"" != 0',    // returns false ("" converts to 0)
+    '"  " != 0',  // returns false ("  " converts to 0)
+    '0 != 1',     // returns true
+    '1 != false', // returns true
+    '0 != true',  // returns true
+    '1 === 1',     // returns true
+    '"1" === 1',   // returns false ("1" is not converted)
+    '1 === true',  // returns false
+    '0 === false', // returns false
+    '"" === 0',    // returns false ("" is not converted)
+    '"  " === 0',  // returns false ("  " is not converted)
+    '0 === 1',     // returns false
+    '1 === false', // returns false
+    '0 === true',  // returns false
+    'var x, y;\nx = {};\ny = x;\nx != y //?', // returns false (refers to same object in memory)
+    'var x, y;\nx = {};\ny = x;\nx != {} //?', // returns true (not the same object)
+    'var x, y;\nx = {};\ny = x;\nx == y //?', // returns true (refers to same object in memory)
+    'var x, y;\nx = {};\ny = x;\nx == {} //?', // returns false (not the same object)
+    'var x, y;\nx = {};\ny = x;\nx === y //?', // returns false (not the same object)
+    'var x, y;\nx = {};\ny = x;\nx === {} //?',
+    'if("")', // false
+    'if("5")', // true
+    'if(0)', // false
+    'if(-1)', // true
+    'if(null)', // false
+    'if(undefined)', // false'// returns false (not the same object)
+    'null == undefined', // returns true
+    'null == false', // returns false
+    'NaN == NaN' // returns false
+  ]);

scripts/controllers/summaryCtrl.js

@@ -1,12 +1,11 @@
 angular.module("typeCoercion")
-    .controller("summaryCtrl", function ($scope, $location, DataHolderService) {
-        'use strict';
-        $scope.tasks = DataHolderService.getTasks();
-        $scope.results = DataHolderService.getResults();
-        ga('send', 'pageview-result');
-
+  .controller("summaryCtrl", function ($scope, $location, DataHolderService) {
+    'use strict';
+    $scope.tasks = DataHolderService.getTasks();
+    $scope.results = DataHolderService.getResults();
+    ga('send', 'pageview-result');
 
     if (!$scope.results.length) {
-            $location.path("/");
-        }
-    });
+      $location.path("/");
+    }
+  });

scripts/controllers/taskCtrl.js

@@ -15,6 +15,7 @@ angular.module("typeCoercion")
             } else {
                 $location.path("/summary");
             }
+            console.log(results);
 
         };
 

scripts/services/DataHolderService.js

@@ -1,52 +1,12 @@
 angular.module("typeCoercion")
-  .factory("DataHolderService", function () {
+  .factory("DataHolderService", function(questions) {
     'use strict';
     function shuffle(o) { //v1.0
       for (var j, x, i = o.length; i; j = Math.floor(Math.random() * i), x = o[--i], o[i] = o[j], o[j] = x);
       return o;
     };
     var results = [];
-    var tasks = shuffle([
-      '1 == 1',     // returns true
-      '"1" == 1',   // returns true ("1" converts to 1)
-      '1 == true',  // returns true
-      '0 == false', // returns true
-      '"" == 0',    // returns true ("" converts to 0)
-      '"  " == 0',  // returns true ("  " converts to 0)
-      '0 == 1',     // returns false
-      '1 == false', // returns false
-      '0 == true',  // returns false
-      '0 != false', // returns false
-      '"" != 0',    // returns false ("" converts to 0)
-      '"  " != 0',  // returns false ("  " converts to 0)
-      '0 != 1',     // returns true
-      '1 != false', // returns true
-      '0 != true',  // returns true
-      '1 === 1',     // returns true
-      '"1" === 1',   // returns false ("1" is not converted)
-      '1 === true',  // returns false
-      '0 === false', // returns false
-      '"" === 0',    // returns false ("" is not converted)
-      '"  " === 0',  // returns false ("  " is not converted)
-      '0 === 1',     // returns false
-      '1 === false', // returns false
-      '0 === true',  // returns false
-      'var x, y;\nx = {};\ny = x;\nx != y //?', // returns false (refers to same object in memory)
-      'var x, y;\nx = {};\ny = x;\nx != {} //?', // returns true (not the same object)
-      'var x, y;\nx = {};\ny = x;\nx == y //?', // returns true (refers to same object in memory)
-      'var x, y;\nx = {};\ny = x;\nx == {} //?', // returns false (not the same object)
-      'var x, y;\nx = {};\ny = x;\nx === y //?', // returns false (not the same object)
-      'var x, y;\nx = {};\ny = x;\nx === {} //?',
-      'if("")', // false
-      'if("5")', // true
-      'if(0)', // false
-      'if(-1)', // true
-      'if(null)', // false
-      'if(undefined)', // false'// returns false (not the same object)
-      'null == undefined', // returns true
-      'null == false', // returns false
-      'NaN == NaN' // returns false
-    ]);
+    var tasks = shuffle(questions);
 
     return {
       getTasks: function () {