Skip to content

Commit 380ea8b

Browse files
committed
BUG32532744: MSI destination folder page lacks details of what installs
Path on Destination Folder page in the MSI is used for no library files, but it were lacking of information of what is installed on it. This patch the default text: "Install MySQL Connector Python vX.Y.Z to:" for the text: "Please select the folder destination for the examples, license and readme files of MySQL Connector Python vX.Y.Z. Destination folder for the libraries can be customized in the next page."
1 parent 0cf7163 commit 380ea8b

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ v8.0.24
1515
- WL#14239: Remove Python 2.7 support
1616
- WL#14212: Support connection close notification
1717
- WL#14027: Add support for Python 3.9
18+
- BUG#32532744: MSI destination folder page lacks details of what installs
1819
- BUG#32497631: Prepared statements fail when parameters are not given
1920
- BUG#32435181: Add support for Django 3.2
2021
- BUG#32162928: Change user command fails on pure python implementation

cpydist/data/msi/WixUI_en-us.wxl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<WixLocalization Culture="en-us" xmlns="http://schemas.microsoft.com/wix/2006/localization">
3+
<String Id="InstallDirDlgFolderLabel" Overridable="yes">Please select the folder destination for the examples, license and readme files of [ProductName]. Destination folder for the libraries can be customized in the next page.</String>
4+
</WixLocalization>

cpydist/wix.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,11 @@ def link(self, wixobj=None, base_path=None, data_path=None):
215215
print("cwd: {}".format(cwd))
216216
os.chdir(base_path)
217217
print("base_path: {}".format(base_path))
218+
wxlfile = os.path.join(data_path, "cpydist\\data\\msi\\WixUI_en-us.wxl")
219+
print("wxlfile loc file: {}".format(wxlfile))
220+
218221
cmdargs = [
222+
r'-loc {0}'.format(wxlfile),
219223
r"-ext WixUIExtension",
220224
r"-cultures:en-us",
221225
r"-nologo",

0 commit comments

Comments
 (0)