Fix for https://issues.sonatype.org/browse/AHC-99

("add a Response.getResponseBodyAsBytes()")

Author: jfarcand

pom.xml

@@ -386,7 +386,8 @@
                         <exclude>**/SpnegoEngine</exclude>                        
                         <exclude>**/Request</exclude>                        
                         <exclude>**/Request$EntityWriter</exclude>                        
-                        <exclude>**/RequestBuilderBase</exclude>                        
+                        <exclude>**/RequestBuilderBase</exclude>
+                        <exclude>**/Response</exclude>
                     </excludes>
                 </configuration>
                 <executions>

src/main/java/com/ning/http/client/Response.java

@@ -44,6 +44,13 @@ public interface Response {
      */
     public String getStatusText();
 
+    /**
+     * Return the entire response body as a byte[].
+     * @return the entire response body as a byte[].
+     * @throws IOException
+     */
+    public byte[] getResponseBodyAsBytes() throws IOException;
+
     /**
      * Returns an input stream for the response body. Note that you should not try to get this more than once,
      * and that you should not close the stream.

src/main/java/com/ning/http/client/providers/apache/ApacheResponse.java

@@ -66,7 +66,11 @@ public String getStatusText() {
     }
 
     /* @Override */
+    public byte[] getResponseBodyAsBytes() throws IOException {
+        return AsyncHttpProviderUtils.contentToByte(bodyParts);
+    }
 
+    /* @Override */
     public String getResponseBody() throws IOException {
         return getResponseBody(DEFAULT_CHARSET);
     }

src/main/java/com/ning/http/client/providers/jdk/JDKResponse.java

@@ -74,6 +74,11 @@ public String getResponseBody() throws IOException {
         return getResponseBody(DEFAULT_CHARSET);
     }
 
+    /* @Override */
+    public byte[] getResponseBodyAsBytes() throws IOException {
+        return AsyncHttpProviderUtils.contentToByte(bodyParts);
+    }
+
     public String getResponseBody(String charset) throws IOException {
         String contentType = getContentType();
         if (contentType != null && charset == null) {

src/main/java/com/ning/http/client/providers/netty/NettyResponse.java

@@ -72,7 +72,11 @@ public String getStatusText() {
     }
 
     /* @Override */
+    public byte[] getResponseBodyAsBytes() throws IOException {
+        return AsyncHttpProviderUtils.contentToByte(bodyParts);
+    }
 
+    /* @Override */
     public String getResponseBody() throws IOException {
         return getResponseBody(DEFAULT_CHARSET);
     }

src/main/java/com/ning/http/client/webdav/WebDavResponse.java

@@ -44,6 +44,11 @@ public String getStatusText() {
         return response.getStatusText();
     }
 
+    /* @Override */
+    public byte[] getResponseBodyAsBytes() throws IOException {
+        return response.getResponseBodyAsBytes();
+    }
+
     public InputStream getResponseBodyAsStream() throws IOException {
         return response.getResponseBodyAsStream();
     }

src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java

@@ -184,6 +184,22 @@ public final static String contentToString(Collection<HttpResponseBodyPart> body
         return b.toString();
     }
 
+    public final static byte[] contentToByte(Collection<HttpResponseBodyPart> bodyParts) throws UnsupportedEncodingException {
+        int size = 0;
+        for (HttpResponseBodyPart body : bodyParts) {
+            size += body.getBodyPartBytes().length;
+        }
+        byte[] bytes = new byte[size];
+        int offset = 0;
+        for (HttpResponseBodyPart body : bodyParts) {
+            byte[] bodyBytes = body.getBodyPartBytes();
+            System.arraycopy(bodyBytes, 0, bytes, offset, bodyBytes.length);
+            offset += bodyBytes.length;
+        }
+
+        return bytes;
+    }
+
     public final static URI getRedirectUri(URI uri, String location) {
         URI newUri = uri.resolve(location);
 

src/test/java/com/ning/http/client/async/AsyncProvidersBasicTest.java

@@ -1602,4 +1602,26 @@ public void asyncHttpClientConfigBeanTest() throws Exception {
         Response r = c.executeRequest(builder.build()).get();
         assertEquals(200, r.getStatusCode());
     }
+
+    @Test(groups = {"default_provider", "async"})
+    public void bodyAsByteTest() throws Throwable {
+        final AsyncHttpClient client = getAsyncHttpClient(new Builder().build());
+        Response r = client.prepareGet(getTargetUrl()).execute().get();
+
+        assertEquals(r.getStatusCode(), 200);
+        assertEquals(r.getResponseBodyAsBytes(), new byte[]{});
+
+        client.close();
+    }
+
+    @Test(groups = {"default_provider", "async"})
+    public void mirrorByteTest() throws Throwable {
+        final AsyncHttpClient client = getAsyncHttpClient(new AsyncHttpClientConfig.Builder().build());
+        Response r = client.preparePost(getTargetUrl()).setBody("MIRROR").execute().get();
+
+        assertEquals(r.getStatusCode(), 200);
+        assertEquals(new String(r.getResponseBodyAsBytes(), "UTF-8"), "MIRROR");
+
+        client.close();
+    }
 }