Skip to content

Deprecate execution_date in the Airflow REST API #29745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
RNHTTR opened this issue Feb 24, 2023 · 6 comments
Closed
1 of 2 tasks

Deprecate execution_date in the Airflow REST API #29745

RNHTTR opened this issue Feb 24, 2023 · 6 comments
Assignees
Labels
area:API Airflow's REST/HTTP API good first issue kind:task A task that needs to be completed as part of a larger issue

Comments

@RNHTTR
Copy link
Contributor

RNHTTR commented Feb 24, 2023

Apache Airflow version

2.5.1

What happened

execution_date is used in place of logical_date in all relevant Airflow REST API calls (e.g. set_task_instance_state) except for trigger dag run.

What you think should happen instead

execution_date should be deprecated throughout Airflow

How to reproduce

Try to use logical_date in an Airflow REST API call

Operating System

n/a

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else

logical_date should also replace execution_date in the Airflow UI for the "Task Instance Details" view.

Related: #26916

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@RNHTTR RNHTTR added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Feb 24, 2023
@pierrejeambrun pierrejeambrun added good first issue area:API Airflow's REST/HTTP API and removed needs-triage label for new issues that we didn't triage yet kind:bug This is a clearly a bug area:core labels Feb 24, 2023
@josh-fell josh-fell added the kind:task A task that needs to be completed as part of a larger issue label Feb 24, 2023
@pierrejeambrun
Copy link
Member

+1

We might also want to handle other related fields such as:

  • execution_date_gte
  • execution_date_lte

We can use the deprecated flag of OpenAPI spec to mark query params and schema fields deprecated, such as:
image
image

A follow up for this would be to update the front end code to not use these deprecated fields.

@eladkal
Copy link
Contributor

eladkal commented Feb 26, 2023

+1 and probably #26916 should follow next

@potiuk
Copy link
Member

potiuk commented Feb 26, 2023

+1

@dejadunlap
Copy link

@hussein-awala are you still working on this pull request? If not, I would love to help out

@hussein-awala
Copy link
Member

@dejadunlap I never had the time to finish my PR, I just closed it and assigned you this issue

@pierrejeambrun
Copy link
Member

This is not used anymore in the API or UI in AF3. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants