Skip to content

Re-implement Slider in Numerical Range filter #33150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geido opened this issue Apr 16, 2025 · 1 comment
Open

Re-implement Slider in Numerical Range filter #33150

geido opened this issue Apr 16, 2025 · 1 comment
Assignees
Labels
change:frontend Requires changing the frontend

Comments

@geido
Copy link
Member

geido commented Apr 16, 2025

Description

PR #31726 has removed the slider as a way to configure numerical range filters. However, we have received feedback from the community that the slider could still serve some purposes.

  • The slider would allow to specify just one of the values, removing the dependency on both values as it is the case currently
    The slider would simplify configuring over large ranges instead of having to type a value or increase a value using the Input Number arrows.

For the reasons above we would like to introduce the slider AND / OR the numerical inputs as ways to configure the numerical range filter.

Objectives

  • Add a range type option (Slider, Range inputs, Slider and range inputs).
  • In the inputs, placeholders should show the default min and max ranges from the dataset.
  • Add metadata text "Choose numbers between [x] and [x]" in vertical filter bar and same text in tooltip for vertical filter bar (From filters left pane, click on gear icon, then select orientation of the filter bar).
  • In horizontal mode, when both slider and inputs are shown, the slider should be rendered first followed by the inputs inline.
  • Make sure errors also mention actual ranges as shown in the screenshot. Use the metadata under the filter for vertical mode. For horizontal mode refer to the screenshots below for the expected behavior of error states.
  • When showing both slider and inputs, slider and inputs should be updated dynamically based on the actions that are happening in one or the other, so if I am using slider to define range, numbers in inputs should be dynamically updated.
  • Remove the need of having both values configured. Allow to keep one of the two empty.
  • Check: Make sure the "Single value" (configurable in filter configurations) option continues to work with these changes.

Please, refer to the screenshots below for more info on the desired implementation.

Image
Image
Image
Image
Image
Image
Image
Image
Image
Image
Image

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Apr 16, 2025
@payose
Copy link

payose commented Apr 16, 2025

Starting work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend
Projects
None yet
Development

No branches or pull requests

3 participants
@geido @payose and others