Prevent multiple close of AsyncHttpProvider and NettyAsyncHttpProvider, close AsyncHttpClient#191

Author: Stephane Landelle

src/main/java/com/ning/http/client/AsyncHttpClient.java

@@ -365,8 +365,9 @@ public AsyncHttpProvider getProvider() {
      * Close the underlying connections.
      */
     public void close() {
-        httpProvider.close();
-        isClosed.set(true);
+        if (isClosed.compareAndSet(false, true)) {
+            httpProvider.close();
+        }
     }
 
     /**

src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java

@@ -875,33 +875,34 @@ else if (uri.getRawQuery() != null)
     }
 
     public void close() {
-        isClose.set(true);
-        try {
-            connectionsPool.destroy();
-            openChannels.close();
-
-            for (Channel channel : openChannels) {
-                ChannelHandlerContext ctx = channel.getPipeline().getContext(NettyAsyncHttpProvider.class);
-                if (ctx.getAttachment() instanceof NettyResponseFuture<?>) {
-                    NettyResponseFuture<?> future = (NettyResponseFuture<?>) ctx.getAttachment();
-                    future.cancelTimeouts();
+        if (isClose.compareAndSet(false, true)) {
+            try {
+                connectionsPool.destroy();
+                openChannels.close();
+
+                for (Channel channel : openChannels) {
+                    ChannelHandlerContext ctx = channel.getPipeline().getContext(NettyAsyncHttpProvider.class);
+                    if (ctx.getAttachment() instanceof NettyResponseFuture<?>) {
+                        NettyResponseFuture<?> future = (NettyResponseFuture<?>) ctx.getAttachment();
+                        future.cancelTimeouts();
+                    }
                 }
-            }
 
-            config.executorService().shutdown();
-            config.reaper().shutdown();
-            if (this.allowReleaseSocketChannelFactory) {
-                socketChannelFactory.releaseExternalResources();
-                plainBootstrap.releaseExternalResources();
-                secureBootstrap.releaseExternalResources();
-                webSocketBootstrap.releaseExternalResources();
-                secureWebSocketBootstrap.releaseExternalResources();
-            }
+                config.executorService().shutdown();
+                config.reaper().shutdown();
+                if (this.allowReleaseSocketChannelFactory) {
+                    socketChannelFactory.releaseExternalResources();
+                    plainBootstrap.releaseExternalResources();
+                    secureBootstrap.releaseExternalResources();
+                    webSocketBootstrap.releaseExternalResources();
+                    secureWebSocketBootstrap.releaseExternalResources();
+                }
 
-            hashedWheelTimer.stop();
+                hashedWheelTimer.stop();
 
-        } catch (Throwable t) {
-            log.warn("Unexpected error on close", t);
+            } catch (Throwable t) {
+                log.warn("Unexpected error on close", t);
+            }
         }
     }