Skip to content

Commit 2ae9ee1

Browse files
committed
Rules for contributing
1 parent fcd23ef commit 2ae9ee1

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

README.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ DragSortListView
44
News
55
----
66

7+
**April 2, 2013**: Hey all. If you want to send a pull request,
8+
please read the [Contributing](https://github.com/drag-sort-listview#contributing) section first. Thanks!
9+
710
**Feb. 9, 2013**: Version 0.6.0. Consolidated remove modes to
811
`click_remove` and `fling_remove`. No more fling remove while
912
dragging; fling anywhere on item to remove it.
@@ -388,6 +391,27 @@ project in the Package Explorer and select Properties. Pick the "Android" page,
388391
and click "Add..." from the bottom half. You should see a list including the
389392
DSLV project as well as any others in your workspace.
390393

394+
Contributing
395+
------------
396+
397+
First of all, thank you! Many of your pull requests have added
398+
tremendous value to this project. Your efforts are truly appreciated!
399+
400+
Now that the project is fairly mature, I would like to lay out
401+
some (loose) rules for future pull requests. So far I have
402+
only one (of course, you should help me add more). Here's the list:
403+
404+
* Avoid pull requests that are small tweaks to default
405+
DragSortController behavior. This class is merely a guide/helper
406+
for creating more complex drag-sort interactions. For example,
407+
if you don't
408+
like the feel of the default fling-remove initiation for your
409+
app, then you should not create a pull request that "fixes"
410+
the behavior. Rather, try to modify or subclass DragSortController
411+
for your particular needs. That said, if a "must-have" touch
412+
pattern arises, I think there is some wiggle room in this rule.
413+
414+
391415
Debugging
392416
---------
393417

0 commit comments

Comments
 (0)