Skip to content

Commit 4c13ccf

Browse files
committed
rename LedFeedbackClass::poll into LedFeedbackClass::update
1 parent 90d1dfa commit 4c13ccf

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

src/NetworkConfigurator.cpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ NetworkConfiguratorClass::NetworkConfiguratorClass(ConnectionHandler &connection
4545
_optionUpdateTimer.begin(NC_UPDATE_NETWORK_OPTIONS_TIMER_ms); //initialize the timer before calling begin
4646
_agentsManager = &AgentsManagerClass::getInstance();
4747
_resetInput = &ResetInput::getInstance();
48+
_ledFeedback = &LEDFeedbackClass::getInstance();
4849
}
4950

5051
bool NetworkConfiguratorClass::begin() {
@@ -57,7 +58,7 @@ bool NetworkConfiguratorClass::begin() {
5758
_state = NetworkConfiguratorStates::READ_STORED_CONFIG;
5859
#endif
5960
memset(&_networkSetting, 0x00, sizeof(models::NetworkSetting));
60-
LEDFeedbackClass::getInstance().begin();
61+
_ledFeedback->begin();
6162
#ifdef BOARD_HAS_WIFI
6263
String fv = WiFi.firmwareVersion();
6364
if (fv < WIFI_FIRMWARE_LATEST_VERSION) {
@@ -85,7 +86,7 @@ bool NetworkConfiguratorClass::begin() {
8586

8687
NetworkConfiguratorStates NetworkConfiguratorClass::update() {
8788
NetworkConfiguratorStates nextState = _state;
88-
LEDFeedbackClass::getInstance().poll();//TODO rename in update
89+
_ledFeedback->update();
8990

9091
switch (_state) {
9192
#if ZERO_TOUCH_ENABLED
@@ -342,7 +343,7 @@ bool NetworkConfiguratorClass::handleConnectRequest() {
342343
if (!_kvstore->begin()) {
343344
DEBUG_ERROR("NetworkConfiguratorClass::%s error initializing kvstore", __FUNCTION__);
344345
sendStatus(StatusMessage::ERROR_STORAGE_BEGIN);
345-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
346+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
346347
return false;
347348
}
348349
bool storeResult = _kvstore->putBytes(STORAGE_KEY, (uint8_t *)&_networkSetting, sizeof(models::NetworkSetting));
@@ -351,15 +352,15 @@ bool NetworkConfiguratorClass::handleConnectRequest() {
351352
if (!storeResult) {
352353
DEBUG_ERROR("NetworkConfiguratorClass::%s error saving network settings", __FUNCTION__);
353354
sendStatus(StatusMessage::ERROR);
354-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
355+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
355356
return false;
356357
}
357358
}
358359

359360
if (_connectionHandlerIstantiated) {
360361
if(disconnectFromNetwork() == ConnectionResult::FAILED) {
361362
sendStatus(StatusMessage::ERROR);
362-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
363+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
363364
return false;
364365
}
365366
}
@@ -370,7 +371,7 @@ bool NetworkConfiguratorClass::handleConnectRequest() {
370371
}
371372

372373
_connectionHandlerIstantiated = true;
373-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::CONNECTING_TO_NETWORK);
374+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::CONNECTING_TO_NETWORK);
374375
return true;
375376
}
376377

@@ -460,7 +461,7 @@ NetworkConfiguratorStates NetworkConfiguratorClass::handleReadStorage() {
460461
if (!_kvstore->begin()) {
461462
DEBUG_ERROR("NetworkConfiguratorClass::%s error initializing kvstore", __FUNCTION__);
462463
sendStatus(StatusMessage::ERROR_STORAGE_BEGIN);
463-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
464+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::ERROR);
464465
return NetworkConfiguratorStates::ERROR;
465466
}
466467

@@ -539,7 +540,7 @@ NetworkConfiguratorStates NetworkConfiguratorClass::handleConfigured() {
539540
bool configInprogress = _agentsManager->isConfigInProgress();
540541

541542
if (configInprogress) {
542-
LEDFeedbackClass::getInstance().setMode(LEDFeedbackClass::LEDFeedbackMode::PEER_CONNECTED);
543+
_ledFeedback->setMode(LEDFeedbackClass::LEDFeedbackMode::PEER_CONNECTED);
543544
}
544545

545546
_agentsManager->poll();

src/NetworkConfigurator.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <Arduino_TimedAttempt.h>
1818
#include <Arduino_KVStore.h>
1919
#include "Utility/ResetInput/ResetInput.h"
20+
#include "Utility/LEDFeedback/LEDFeedback.h"
2021

2122
enum class NetworkConfiguratorStates { ZERO_TOUCH_CONFIG,
2223
READ_STORED_CONFIG,
@@ -141,6 +142,7 @@ class NetworkConfiguratorClass {
141142
static inline models::NetworkSetting _networkSetting;
142143
bool _connectionHandlerIstantiated;
143144
ResetInput *_resetInput;
145+
LEDFeedbackClass *_ledFeedback;
144146
bool _bleEnabled;
145147
TimedAttempt _connectionTimeout;
146148
TimedAttempt _connectionRetryTimer;

src/Utility/LEDFeedback/LEDFeedback.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ void LEDFeedbackClass::restart() {
197197
stopped = false;
198198
}
199199

200-
void LEDFeedbackClass::poll() {
200+
void LEDFeedbackClass::update() {
201201
if(stopped) {
202202
return;
203203
}

src/Utility/LEDFeedback/LEDFeedback.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class LEDFeedbackClass {
2525
void setMode(LEDFeedbackMode mode);
2626
void stop();
2727
void restart();
28-
void poll();
28+
void update();
2929
private:
3030
LEDFeedbackClass() {};
3131
void turnON();

0 commit comments

Comments
 (0)