Skip to content

Commit 8f2d773

Browse files
cmagliefacchinm
authored andcommitted
cmake: some variable renames
libs -> dynamicLibsFromGccMinusL staticLibsFiles -> staticLibs staticLibsFile -> staticLib
1 parent cc5f090 commit 8f2d773

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

create_cmake_rule.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
127127
// Extract CFLAGS, CPPFLAGS and LDFLAGS
128128
var defines []string
129129
var linkerflags []string
130-
var libs []string
130+
var dynamicLibsFromGccMinusL []string
131131
var linkDirectories []string
132132

133-
extractCompileFlags(ctx, constants.RECIPE_C_COMBINE_PATTERN, &defines, &libs, &linkerflags, &linkDirectories, logger)
134-
extractCompileFlags(ctx, constants.RECIPE_C_PATTERN, &defines, &libs, &linkerflags, &linkDirectories, logger)
135-
extractCompileFlags(ctx, constants.RECIPE_CPP_PATTERN, &defines, &libs, &linkerflags, &linkDirectories, logger)
133+
extractCompileFlags(ctx, constants.RECIPE_C_COMBINE_PATTERN, &defines, &dynamicLibsFromGccMinusL, &linkerflags, &linkDirectories, logger)
134+
extractCompileFlags(ctx, constants.RECIPE_C_PATTERN, &defines, &dynamicLibsFromGccMinusL, &linkerflags, &linkDirectories, logger)
135+
extractCompileFlags(ctx, constants.RECIPE_CPP_PATTERN, &defines, &dynamicLibsFromGccMinusL, &linkerflags, &linkDirectories, logger)
136136

137137
// Extract folders with .h in them for adding in include list
138138
var headerFiles []string
@@ -141,9 +141,9 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
141141
foldersContainingDotH := findUniqueFoldersRelative(headerFiles, cmakeFolder)
142142

143143
// Extract folders with .a in them for adding in static libs paths list
144-
var staticLibsFiles []string
144+
var staticLibs []string
145145
isStaticLib := func(ext string) bool { return DOTAEXTENSION[ext] }
146-
utils.FindFilesInFolder(&staticLibsFiles, cmakeFolder, isStaticLib, true)
146+
utils.FindFilesInFolder(&staticLibs, cmakeFolder, isStaticLib, true)
147147

148148
// Generate the CMakeLists global file
149149

@@ -169,22 +169,22 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
169169
cmakelist += "set(EXTRA_LIBS_DIRS \"\" CACHE STRING \"Additional paths for dynamic libraries\")\n"
170170

171171
linkGroup := ""
172-
for _, lib := range libs {
172+
for _, lib := range dynamicLibsFromGccMinusL {
173173
// Dynamic libraries should be discovered by pkg_config
174174
cmakelist += "pkg_search_module (" + strings.ToUpper(lib) + " " + lib + ")\n"
175175
relLinkDirectories = append(relLinkDirectories, "${"+strings.ToUpper(lib)+"_LIBRARY_DIRS}")
176176
linkGroup += " " + lib
177177
}
178178
cmakelist += "link_directories (" + strings.Join(relLinkDirectories, " ") + " ${EXTRA_LIBS_DIRS})\n"
179-
for _, staticLibsFile := range staticLibsFiles {
179+
for _, staticLib := range staticLibs {
180180
// Static libraries are fully configured
181-
lib := filepath.Base(staticLibsFile)
181+
lib := filepath.Base(staticLib)
182182
lib = strings.TrimPrefix(lib, "lib")
183183
lib = strings.TrimSuffix(lib, ".a")
184-
if !utils.SliceContains(libs, lib) {
184+
if !utils.SliceContains(dynamicLibsFromGccMinusL, lib) {
185185
linkGroup += " " + lib
186186
cmakelist += "add_library (" + lib + " STATIC IMPORTED)\n"
187-
location := strings.TrimPrefix(staticLibsFile, cmakeFolder)
187+
location := strings.TrimPrefix(staticLib, cmakeFolder)
188188
cmakelist += "set_property(TARGET " + lib + " PROPERTY IMPORTED_LOCATION " + "${PROJECT_SOURCE_DIR}" + location + " )\n"
189189
}
190190
}

0 commit comments

Comments
 (0)