Skip to content

Commit 9e0854a

Browse files
committed
Add now required teamId option to notarization script
The options for the `notarize` call in the script are different depending on the setting of the `tool` option. Now that the `tool` has been changed from the default `legacy` to `notarytool`, there is an additional `teamId` option, which is the Apple Developer Program team ID associated with the macOS signing certificate. Following the convention established in the Arduino IDE, I used an encrypted repository secret to configure the team ID value. This is not absolutely necessary because, unlike some of the other credentials used by the build system, the team ID is not actually a secret and can be seen in plaintext by anyone who examines the notarized application.
1 parent 8c35c33 commit 9e0854a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/build.yml

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5050
AC_USERNAME: ${{ secrets.AC_USERNAME }}
5151
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
52+
AC_TEAM_ID: ${{ secrets.AC_TEAM_ID }}
5253
# AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
5354
# AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
5455
# IS_NIGHTLY: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/main') }}

build_resources/notarize.js

+1
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,6 @@ exports.default = async function notarizing(context) {
4040
appPath: `${appOutDir}/${appName}.app`,
4141
appleId: process.env.AC_USERNAME,
4242
appleIdPassword: process.env.AC_PASSWORD,
43+
teamId: process.env.AC_TEAM_ID,
4344
});
4445
};

0 commit comments

Comments
 (0)