Skip to content

Commit fd8e341

Browse files
committed
Merge branch 'master' of github.com:krausest/js-framework-benchmark
2 parents 4b41f55 + d377dfd commit fd8e341

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ There are currently ~60 framework entries in this repository. Installing (and ma
4646

4747
### 1. Prerequisites
4848

49-
Have *node.js (>=7.6)* installed. If you want to do yourself a favour use nvm for that and install yarn. The benchmark has been tested with node 8.4.0.
49+
Have *node.js (>=10.0)* installed. If you want to do yourself a favour use nvm for that and install yarn. The benchmark has been tested with node v10.16.3.
5050
For some frameworks you'll also need *java* (>=8, e.g. openjdk-8-jre on ubuntu).
5151
Please make sure that the following command work before trying to build:
5252
```
@@ -260,6 +260,7 @@ Contributions are very welcome. Please use the following rules:
260260
* **Please make sure your implementation is validated by the test tool.** cd to webdriver-ts and invoke it with `npm run check [keyed|non-keyed]/[FrameworkName]`. It'll print an error if your framework behaves other as specified. It'll print a big ERROR explaining if it isn't happy with the implementation.
261261
* Please don't commit any of the result file webdriver-ts/table.html, webdriver-ts-results/src/results.ts or webdriver-ts-results/table.html. I use to run the benchmarks after merging and publish updated (temporary) results.
262262
* The latest stable chrome can be used regarding web features and language level (babel-preset-env "last 1 chrome versions")
263+
* The vanillajs implementations and some others include code that try to approximate the repaint duration through javascript code. Implemenatations are not required to include that measurement. Remember: The real measurements are taken by the automated test driver by examining chrome timeline entries.
263264
* **Please don't over-optimize. Other contributors will review your implementation so beware of discussions ([#521](https://github.com/krausest/js-framework-benchmark/pull/521), [#519](https://github.com/krausest/js-framework-benchmark/pull/519), [#430](https://github.com/krausest/js-framework-benchmark/issues/430)) and rejection if the community finds you cheating. When are you safe?**
264265
* If the initial rendering is able to render the selection state
265266
* The implementation uses only the idiomatic style of its library

0 commit comments

Comments
 (0)