Small improvements in error handler

Author: Fogolan

tools/office-cmdlet-updater/controllers/cli.controller.js

@@ -1,12 +1,26 @@
 class CliController {
-	constructor(cliService, cmdletService, markdownController) {
-		this.cliServoce = cliService;
+	constructor(
+		cliService,
+		cmdletService,
+		markdownController,
+		powerShellService
+	) {
+		this.cliService = cliService;
 		this.cmdletService = cmdletService;
 		this.markdownController = markdownController;
+		this.powerShellService = powerShellService;
+	}
+	start(argv) {
+		try {
+			this.startCli(argv);
+		} catch (e) {
+			this.powerShellService.dispose();
+			console.error(e.message);
+		}
 	}
 
 	startCli(argv) {
-		this.cliServoce.addOption({
+		this.cliService.addOption({
 			option: '-m --module <module>',
 			description: 'update documentation for module',
 			defaultValue: 'all',
@@ -21,27 +35,25 @@ class CliController {
 			}
 		});
 
-		this.cliServoce.addOption({
+		this.cliService.addOption({
 			option: '-c --cmdlet <cmdet>',
 			description: 'update documentation for cmdlet in module',
 			action: (cli) => {
 				const { module, cmdlet } = cli;
 
 				if (module === 'all' && cmdlet) {
-					throw new Error('You must specify a module for cmdet.');
+					throw new Error('You must specify a module for cmdlet.');
 				}
 			}
 		});
 
-		this.cliServoce.start(argv, async (cli) => {
+		this.cliService.start(argv, async (cli) => {
 			const { module, cmdlet } = cli;
 
-			this.markdownController.updateMarkdown({
+			await this.markdownController.updateMarkdown({
 				moduleName: module,
 				cmdlet
 			});
-			console.log(module);
-			console.log(cmdlet);
 		});
 	}
 }

tools/office-cmdlet-updater/controllers/markdown.controller.js

@@ -23,7 +23,7 @@ class MarkdownController {
 
 				if (err) {
 					this.powerShellService.dispose();
-					throw new Error(err);
+					console.error(err.message);
 				}
 			}
 		);

tools/office-cmdlet-updater/index.js

@@ -1,9 +1,5 @@
 const container = require('./helpers/di.container')();
 
-try {
-	const cliController = container.resolve('cliController');
+const cliController = container.resolve('cliController');
 
-	cliController.startCli(process.argv);
-} catch (e) {
-	console.log(e);
-}
+cliController.start(process.argv);

tools/office-cmdlet-updater/services/markdown.service.js

@@ -40,6 +40,12 @@ class MarkdownService {
 			(file) => this._filterCmdlets(file, cmdlet)
 		);
 
+		if (!mdFiles.length) {
+			throw new Error(
+				`Can't find cmdlet "${cmdlet}" in module "${doc.name}"`
+			);
+		}
+
 		mdFiles.forEach((file) => {
 			this.queue
 				.push({ file, doc })