replace mocks with doubles

Author: Austin Schneider

spec/controllers/alerts_controller_spec.rb

@@ -35,7 +35,7 @@
       ].each do |params, attrs|
         context "when the params is #{params.inspect}" do
           before do
-            @alert = mock(Alert)
+            @alert = double('alert')
             subject.stub(:params) { params }
             Alert.stub(:new) { |args| @alert if args == attrs }
           end

spec/helpers/application_helper_spec.rb

@@ -23,7 +23,7 @@
 
   describe "paginated_locations" do
     it "returns the locations, paginated" do
-      paginated_locations = mock Object
+      paginated_locations = double 'object'
       subject.locations.stub(:paginate) do |page, per_page|
         paginated_locations if page == 7 && per_page == 3
       end
@@ -36,7 +36,7 @@
   describe "render_paginated_locations" do
     context "when there are paginated locations" do
       before do
-        @locs = [mock(Location)]
+        @locs = [double('location')]
         subject.stub(:paginated_locations) { @locs }
       end
       it "renders the locations table" do
@@ -54,8 +54,8 @@
   describe "render_alerts" do
     context "when there are alerts" do
       before do
-        @rendered_alerts = mock(Object)
-        alerts = [mock(Alert)]
+        @rendered_alerts = double('object')
+        alerts = [double('alert')]
         subject.stub(:alerts) { alerts }
         view.stub(:render) do |*args|
           @rendered_alerts if args == ['alerts/table', {alerts: alerts}]
@@ -75,8 +75,8 @@
   describe "render_email_callbacks" do
     context "when there are email callbacks" do
       before do
-        @rendered_email_callbacks = mock(Object)
-        email_callbacks = [mock(EmailCallback)]
+        @rendered_email_callbacks = double('object')
+        email_callbacks = [double('email_callback')]
         subject.stub(:email_callbacks) { email_callbacks }
         view.stub(:render) do |*args|
           if args == ['email_callbacks/table', {email_callbacks: email_callbacks}]

spec/lib/pinger/alert/mailer_spec.rb

@@ -6,9 +6,9 @@
     subject { described_class.notification(alert) }
 
     let :alert do
-      mock Alert,
-        location: mock(Location, title: 'Google Homepage'),
-        email_callback: mock(EmailCallback, to: '[email protected]'),
+      double 'alert',
+        location: double('location', title: 'Google Homepage'),
+        email_callback: double('email_callback', to: '[email protected]'),
         code_is_not: '201'
     end
 

spec/lib/pinger/alert/presenter/attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Alert::Presenter::Attribute do
 
   let :alert_presenter do
-    mock Alert::Presenter, alert: mock(Alert)
+    double 'Alert::Presenter', alert: double('Alert')
   end
 
   subject { described_class.new alert_presenter }
@@ -12,8 +12,8 @@
 
   [:alert].each do |method|
     it "delegates #{method} to the alert presenter" do
-      result = mock Object
-      args = [mock(Object), mock(Object)]
+      result = double 'Object'
+      args = [double('Object'), double('Object')]
       alert_presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/alert/presenter/code_is_not_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Alert::Presenter::CodeIsNotAttribute do
 
   let :alert_presenter do
-    mock Alert::Presenter, alert: mock(Alert)
+    double 'Alert::Presenter', alert: double('Alert')
   end
 
   subject { described_class.new alert_presenter }

spec/lib/pinger/alert/presenter/email_callback_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Alert::Presenter::EmailCallbackAttribute do
 
   let :alert_presenter do
-    mock Alert::Presenter, alert: mock(Alert)
+    double 'Alert::Presenter', alert: double('Alert')
   end
 
   subject { described_class.new alert_presenter }
@@ -12,8 +12,8 @@
 
   [:email_callback_options_for_select].each do |method|
     it "delegates #{method} to the alert presenter" do
-      result = mock Object
-      args = [mock(Object), mock(Object)]
+      result = double 'Object'
+      args = [double('Object'), double('Object')]
       alert_presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/alert/presenter/location_attribute_spec.rb

@@ -3,8 +3,8 @@
 describe Alert::Presenter::LocationAttribute do
 
   let :alert_presenter do
-    mock Alert::Presenter,
-      alert: mock(Alert, :location => mock(Location, :title => 'title'))
+    double 'Alert::Presenter',
+      alert: double('Alert', :location => double('Location', :title => 'title'))
   end
 
   subject { described_class.new alert_presenter }
@@ -13,8 +13,8 @@
 
   [:location_options_for_select].each do |method|
     it "delegates #{method} to the alert presenter" do
-      result = mock Object
-      args = [mock(Object), mock(Object)]
+      result = double 'Object'
+      args = [double('Object'), double('Object')]
       alert_presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/alert/presenter/times_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Alert::Presenter::TimesAttribute do
 
   let :alert_presenter do
-    mock Alert::Presenter, alert: mock(Alert)
+    double 'Alert::Presenter', alert: double('Alert')
   end
 
   subject { described_class.new alert_presenter }

spec/lib/pinger/alert/presenter_spec.rb

@@ -6,16 +6,16 @@
 
   subject { described_class.new alert, view }
 
-  let(:alert) { mock Alert, code_is_not: '400', times: 23 }
+  let(:alert) { double 'alert', code_is_not: '400', times: 23 }
 
   describe "location_options_for_select" do
     context "when the template has locations" do
       before do
         view.stub :locations do
           [
-            mock(Location, id: 1, title: 'A'),
-            mock(Location, id: 2, title: 'B'),
-            mock(Location, id: 3, title: 'C')
+            double('location', id: 1, title: 'A'),
+            double('location', id: 2, title: 'B'),
+            double('location', id: 3, title: 'C')
           ]
         end
       end

spec/lib/pinger/alert_spec.rb

@@ -43,7 +43,7 @@
 
     describe "deliver!" do
       it "tells a notification email to deliver" do
-        notif = mock Mail::Message, deliver: nil
+        notif = double 'message', deliver: nil
         Alert::Mailer.stub(:notification) { |a| notif if a == subject }
 
         notif.should_receive :deliver

spec/lib/pinger/email_callback/presenter/attribute_spec.rb

@@ -3,7 +3,7 @@
 describe EmailCallback::Presenter::Attribute do
 
   let :email_callback_presenter do
-    mock EmailCallback::Presenter, email_callback: mock(EmailCallback)
+    double 'EmailCallback::Presenter', email_callback: double('EmailCallback')
   end
 
   subject { described_class.new email_callback_presenter }
@@ -12,8 +12,8 @@
 
   [:email_callback].each do |method|
     it "delegates #{method} to the email callback presenter" do
-      result = mock Object
-      args = [mock(Object), mock(Object)]
+      result = double 'Object'
+      args = [double('Object'), double('Object')]
       email_callback_presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/email_callback/presenter/email_spec.rb

@@ -3,7 +3,7 @@
 describe EmailCallback::Presenter::EmailAttribute do
 
   let :email_callback_presenter do
-    mock EmailCallback::Presenter, email_callback: mock(EmailCallback, to: '[email protected]')
+    double 'EmailCallback::Presenter', email_callback: double('EmailCallback', to: '[email protected]')
   end
 
   subject { described_class.new email_callback_presenter }

spec/lib/pinger/email_callback/presenter/label_spec.rb

@@ -3,7 +3,7 @@
 describe EmailCallback::Presenter::LabelAttribute do
 
   let :email_callback_presenter do
-    mock EmailCallback::Presenter, email_callback: mock(EmailCallback, label: 'label')
+    double 'EmailCallback::Presenter', email_callback: double('EmailCallback', label: 'label')
   end
 
   subject { described_class.new email_callback_presenter }

spec/lib/pinger/email_callback/presenter_spec.rb

@@ -13,7 +13,7 @@
   [['email', 'to'], ['label', 'label']].each do |prefix, attr_name|
     describe "#{prefix}_errors" do
       it "renders form errors for the email callback's #{attr_name}" do
-        form_errors = mock(Object)
+        form_errors = double('Object')
         subject.stub(:render_form_errors) { |a| form_errors if a == attr_name }
 
         subject.send("#{prefix}_errors").should == form_errors

spec/lib/pinger/location/instance_methods_spec.rb

@@ -34,7 +34,7 @@
   describe "schedule_ping!", freeze_time: true do
     before do
       subject.save!
-      @next_ping = mock Ping
+      @next_ping = double 'Ping'
       subject.stub(:next_ping_to_schedule) { @next_ping }
       create :ping, performed_at: 1.minute.ago
     end

spec/lib/pinger/location/presenter/attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Location::Presenter::Attribute do
 
   let :location_presenter do
-    mock Location::Presenter, location: mock(Location)
+    double 'Location::Presenter', location: double('Location')
   end
 
   subject { described_class.new location_presenter }
@@ -12,8 +12,8 @@
 
   [:location].each do |method|
     it "delegates #{method} to the email callback presenter" do
-      result = mock Object
-      args = [mock(Object), mock(Object)]
+      result = double 'Object'
+      args = [double('Object'), double('Object')]
       location_presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/location/presenter/http_method_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Location::Presenter::HttpMethodAttribute do
 
   let :location_presenter do
-    mock Location::Presenter, :location => mock(Location, :http_method => 'SFJLSFJ')
+    double 'Location::Presenter', :location => double('Location', :http_method => 'SFJLSFJ')
   end
 
   subject { described_class.new location_presenter }

spec/lib/pinger/location/presenter/seconds_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Location::Presenter::SecondsAttribute do
 
   let :location_presenter do
-    mock Location::Presenter, :location => mock(Location, :seconds => 34857)
+    double 'Location::Presenter', :location => double('Location', :seconds => 34857)
   end
 
   subject { described_class.new location_presenter }

spec/lib/pinger/location/presenter/title_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Location::Presenter::TitleAttribute do
 
   let :location_presenter do
-    mock Location::Presenter, :location => mock(Location, :title => 'Abc')
+    double 'Location::Presenter', :location => double('Location', :title => 'Abc')
   end
 
   subject { described_class.new location_presenter }

spec/lib/pinger/location/presenter/url_attribute_spec.rb

@@ -3,7 +3,7 @@
 describe Location::Presenter::UrlAttribute do
 
   let :location_presenter do
-    mock Location::Presenter, :location => mock(Location, :url => 'http://google.com/')
+    double 'Location::Presenter', :location => double('Location', :url => 'http://google.com/')
   end
 
   subject { described_class.new location_presenter }

spec/lib/pinger/location/presenter_spec.rb

@@ -61,7 +61,7 @@
 
   describe "paginated_pings" do
     it "returns the pings, paginated" do
-      paginated_pings = mock Object
+      paginated_pings = double 'Object'
       subject.pings.stub(:paginate) do |page, per_page|
         paginated_pings if page == 7 && per_page == 3
       end
@@ -74,7 +74,7 @@
   describe "render_pings" do
     context "when there are paginated pings" do
       before do
-        @paginated_pings = [mock(Ping)]
+        @paginated_pings = [double('Ping')]
         subject.stub(:paginated_pings) { @paginated_pings }
       end
       it "tells the view to render the pings table" do

spec/lib/pinger/ping/instance_methods_spec.rb

@@ -23,7 +23,7 @@
   describe "perform!" do
     before do
       subject.stub :deliver_applicable_alerts!
-      subject.location.stub(:perform_request) { mock Object, code: '234' }
+      subject.location.stub(:perform_request) { double 'Object', code: '234' }
     end
 
     it "tells the location to perform the request" do
@@ -72,8 +72,8 @@
   describe "deliver_applicable_alerts!" do
     it "tells the alerts, that have the conditions met, to deliver" do
       alerts = [
-        mock(Alert, :conditions_met? => true),
-        mock(Alert, :conditions_met? => false)
+        double('Alert', :conditions_met? => true),
+        double('Alert', :conditions_met? => false)
       ]
       subject.stub(:alerts) { alerts }
       alerts[0].should_receive :deliver!

spec/lib/pinger/poser/presenter/attribute_spec.rb

@@ -2,7 +2,7 @@
 
 describe Poser::Presenter::Attribute do
 
-  let(:presenter) { mock Poser::Presenter }
+  let(:presenter) { double 'Poser::Presenter' }
 
   subject { described_class.new presenter }
 
@@ -12,28 +12,28 @@
 
   describe "<=>" do
     it "returns the comparison of the presenter and the other objects presenter" do
-      result = mock Object
-      other_subject = mock Object, presenter: mock(Object)
+      result = double 'Object'
+      other_subject = double 'Object', presenter: double('Object')
       presenter.should_receive(:<=>).with(other_subject.presenter).and_return(result)
       (subject <=> other_subject).should == result
     end
   end
 
   [:form_builder, :render].each do |method|
     it "delegates #{method} to the presenter" do
-      result = mock(Object)
-      args = [mock(Object), mock(Object)]
+      result = double('Object')
+      args = [double('Object'), double('Object')]
       presenter.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end
   end
 
   [:text_field, :select].each do |method|
     it "delegates #{method} to the form builder" do
-      form_builder = mock Object
+      form_builder = double 'Object'
       subject.stub(:form_builder) { form_builder }
-      result = mock(Object)
-      args = [mock(Object), mock(Object)]
+      result = double('Object')
+      args = [double('Object'), double('Object')]
       form_builder.should_receive(method).with(*args).and_return(result)
       subject.send(method, *args).should == result
     end

spec/lib/pinger/poser/presenter_spec.rb

@@ -3,7 +3,7 @@
 describe Poser::Presenter do
   include ActionView::TestCase::Behavior
 
-  let(:obj) { mock Object }
+  let(:obj) { double 'Object' }
 
   subject { described_class.new obj, view }
 
@@ -12,7 +12,7 @@
   describe "render_form_errors" do
     before do
       obj.stub(:errors) { {foo: ["is bad", 'is wrong']} }
-      @form_errors = mock(Object)
+      @form_errors = double('Object')
       subject.stub(:render) do |*args|
         if args == ['shared/form_errors', {errors: ["Is bad", 'Is wrong']}]
           @form_errors