remove dumb helpers

Author: Austin Schneider

app/helpers/application_helper.rb

@@ -20,34 +20,10 @@ def paginated_locations
     @paginated_locations ||= locations.paginate params[:page], CONFIG[:app][:locations_per_page]
   end
 
-  def render_paginated_locations
-    if paginated_locations.present?
-      render 'locations/table', locations: paginated_locations
-    else
-      content_tag :p, 'No URLs found.', class: 'empty'
-    end
-  end
-
   def alerts
     @alerts ||= Alert.joins { location }.order { locations.title.asc }
   end
 
-  def render_alerts
-    if alerts.present?
-      render 'alerts/table', alerts: alerts
-    else
-      content_tag :p, 'No alerts found.', class: 'empty'
-    end
-  end
-
-  def render_email_callbacks
-    if email_callbacks.present?
-      render 'email_callbacks/table', email_callbacks: email_callbacks
-    else
-      content_tag :p, 'No email callbacks found.', class: 'empty'
-    end
-  end
-
   def email_callbacks
     @email_callbacks ||= EmailCallback.order { label.asc }
   end

app/views/alerts/index.html.haml

@@ -1,4 +1,7 @@
 #alerts
   %h2 Alerts
 
-  = render_alerts
+  - if alerts.present?
+    = render 'alerts/table', :alerts => alerts
+  - else
+    %p.empty No alerts found.

app/views/email_callbacks/index.html.haml

@@ -3,4 +3,7 @@
 
   %p= link_to 'Add email callback', new_email_callback_path
 
-  = render_email_callbacks
+  - if email_callbacks.present?
+    = render 'email_callbacks/table', :email_callbacks => email_callbacks
+  - else
+    %p.empty No email callbacks found.

app/views/locations/index.html.haml

@@ -8,5 +8,9 @@
     |
     = link_to "Alerts", alerts_path
 
-  = render_paginated_locations
+  - if paginated_locations.present?
+    = render 'locations/table', :locations => paginated_locations
+  - else
+    %p.empty No URLs found.
+
   = paginate paginated_locations

spec/helpers/application_helper_spec.rb

@@ -33,68 +33,6 @@
     end
   end
 
-  describe "render_paginated_locations" do
-    context "when there are paginated locations" do
-      before do
-        @locs = [double('location')]
-        subject.stub(:paginated_locations) { @locs }
-      end
-      it "renders the locations table" do
-        subject.should_receive(:render).with 'locations/table', locations: @locs
-        subject.render_paginated_locations
-      end
-    end
-
-    context "when there are no paginated locations" do
-      before { subject.stub :paginated_locations }
-      it { subject.render_paginated_locations.should =~ /No URLs found/ }
-    end
-  end
-
-  describe "render_alerts" do
-    context "when there are alerts" do
-      before do
-        @rendered_alerts = double('object')
-        alerts = [double('alert')]
-        subject.stub(:alerts) { alerts }
-        view.stub(:render) do |*args|
-          @rendered_alerts if args == ['alerts/table', {alerts: alerts}]
-        end
-      end
-      it "renders the alerts table" do
-        subject.render_alerts.should == @rendered_alerts
-      end
-    end
-
-    context "when there are no alerts" do
-      before { subject.stub :alerts }
-      it { subject.render_alerts.should =~ /No alerts found/ }
-    end
-  end
-
-  describe "render_email_callbacks" do
-    context "when there are email callbacks" do
-      before do
-        @rendered_email_callbacks = double('object')
-        email_callbacks = [double('email_callback')]
-        subject.stub(:email_callbacks) { email_callbacks }
-        view.stub(:render) do |*args|
-          if args == ['email_callbacks/table', {email_callbacks: email_callbacks}]
-            @rendered_email_callbacks
-          end
-        end
-      end
-      it "renders the email callbacks table" do
-        subject.render_email_callbacks.should == @rendered_email_callbacks
-      end
-    end
-
-    context "when there are no email callbacks" do
-      before { subject.stub :email_callbacks }
-      it { subject.render_email_callbacks.should =~ /No email callbacks found/ }
-    end
-  end
-
   describe "alerts" do
     context "when there are alerts" do
       before do