Skip to content

Commit fa55293

Browse files
committed
all requests are utf-8. Don't use the external encoding.
1 parent f6fe174 commit fa55293

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

actionpack/lib/action_dispatch/http/upload.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,9 @@ def size
3333

3434
private
3535
def encode_filename(filename)
36-
# Encode the filename in the default_external encoding, unless it is nil or we're in 1.8
36+
# Encode the filename in the utf8 encoding, unless it is nil or we're in 1.8
3737
if "ruby".encoding_aware? && filename
38-
encoding = Encoding.default_external
39-
filename.force_encoding(encoding)
38+
filename.force_encoding("UTF-8").encode!
4039
else
4140
filename
4241
end

actionpack/test/dispatch/uploaded_file_test.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,7 @@ def test_original_filename
1414
end
1515

1616
if "ruby".encoding_aware?
17-
def test_filename_should_be_in_default_encoding
18-
Encoding.default_external = "UTF-16LE"
19-
uf = Http::UploadedFile.new(:filename => 'foo', :tempfile => Object.new)
20-
assert "UTF-16LE", uf.original_filename.encoding.to_s
21-
22-
Encoding.default_external = "UTF-8"
17+
def test_filename_should_be_in_utf_8
2318
uf = Http::UploadedFile.new(:filename => 'foo', :tempfile => Object.new)
2419
assert "UTF-8", uf.original_filename.encoding.to_s
2520
end

0 commit comments

Comments
 (0)