Change endpoints to implement IEnumerable.

Author: isaacabraham

Elastacloud.AzureManagement.Fluent/Clients/LinuxVirtualMachineClient.cs

@@ -1,4 +1,15 @@
-/*****************************************************************`*******************************************
+using Elastacloud.AzureManagement.Fluent.Clients.Helpers;
+using Elastacloud.AzureManagement.Fluent.Clients.Interfaces;
+using Elastacloud.AzureManagement.Fluent.Commands.Services;
+using Elastacloud.AzureManagement.Fluent.Commands.VirtualMachines;
+using Elastacloud.AzureManagement.Fluent.Commands.VirtualNetworks;
+using Elastacloud.AzureManagement.Fluent.Helpers;
+using Elastacloud.AzureManagement.Fluent.Types;
+using Elastacloud.AzureManagement.Fluent.Types.Exceptions;
+using Elastacloud.AzureManagement.Fluent.Types.VirtualMachines;
+using Elastacloud.AzureManagement.Fluent.Types.VirtualNetworks;
+using Elastacloud.AzureManagement.Fluent.VirtualMachines.Classes;
+/*****************************************************************`*******************************************
  * This software is distributed under a GNU Lesser License by Elastacloud Limited and it is free to         *
  * modify and distribute providing the terms of the license are followed. From the root of the source the   *
  * license can be found in /Resources/license.txt                                                           * 
@@ -9,24 +20,10 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.IO;
 using System.Linq;
-using System.Net;
 using System.Security.Cryptography.X509Certificates;
 using System.Threading;
 using System.Threading.Tasks;
-using Elastacloud.AzureManagement.Fluent.Clients.Helpers;
-using Elastacloud.AzureManagement.Fluent.Clients.Interfaces;
-using Elastacloud.AzureManagement.Fluent.Commands.Blobs;
-using Elastacloud.AzureManagement.Fluent.Commands.Services;
-using Elastacloud.AzureManagement.Fluent.Commands.VirtualMachines;
-using Elastacloud.AzureManagement.Fluent.Commands.VirtualNetworks;
-using Elastacloud.AzureManagement.Fluent.Helpers;
-using Elastacloud.AzureManagement.Fluent.Types;
-using Elastacloud.AzureManagement.Fluent.Types.Exceptions;
-using Elastacloud.AzureManagement.Fluent.Types.VirtualMachines;
-using Elastacloud.AzureManagement.Fluent.Types.VirtualNetworks;
-using Elastacloud.AzureManagement.Fluent.VirtualMachines.Classes;
 
 namespace Elastacloud.AzureManagement.Fluent.Clients
 {
@@ -583,7 +580,7 @@ public List<VmHost> GetHostDetails(string cloudServiceName)
                 HostName = vm.RoleName,
                 IpAddress = vm.IPAddress,
                 RoleName = vm.RoleName,
-                Endpoints = vm.NetworkConfigurationSet.InputEndpoints
+                Endpoints = vm.NetworkConfigurationSet.InputEndpoints.Endpoints.AsReadOnly()
             }));
             return hosts;
         }

Elastacloud.AzureManagement.Fluent/Types/Virtual Machines/InputEndpoints.cs

@@ -23,14 +23,14 @@ public class InputEndpoints : ICustomXmlSerializer
         /// <summary>
         /// The local collection of InputEndpoint values
         /// </summary>
-        private readonly List<InputEndpoint> _endpoints;
+        public List<InputEndpoint> Endpoints { get; private set; }
 
         /// <summary>
         /// Creates a new instance of the InputEndpoints collection class
         /// </summary>
         public InputEndpoints()
         {
-            _endpoints = new List<InputEndpoint>();
+            Endpoints = new List<InputEndpoint>();
         }
 
         /// <summary>
@@ -41,22 +41,22 @@ public void AddEndpoint(InputEndpoint endpoint)
         {
             // check to see whether the endpoint exists or not
             IEnumerable<InputEndpoint> endpoints =
-                _endpoints.Where(a => a.LocalPort == endpoint.LocalPort || (a.Port == endpoint.LocalPort && a.Port != 0)
+                Endpoints.Where(a => a.LocalPort == endpoint.LocalPort || (a.Port == endpoint.LocalPort && a.Port != 0)
                                       || a.EndpointName == endpoint.EndpointName);
             if (endpoints.Any())
                 throw new ApplicationException(
                     "An endpoint containing the Local/Remote port and/or endpoint name already exists");
             // continue if it doesn't
-            _endpoints.Add(endpoint);
+            Endpoints.Add(endpoint);
         }
 
         public InputEndpoint this[int index]
         {
             get
             {
-                if(index < 0 || index >= _endpoints.Count)
+                if(index < 0 || index >= Endpoints.Count)
                     throw new ArgumentOutOfRangeException("endpoint index out of range");
-                return _endpoints[index];
+                return Endpoints[index];
             }
         }
 
@@ -70,7 +70,7 @@ public XElement GetXmlTree()
         {
             var inputEndpoints = new XElement(Namespaces.NsWindowsAzure + "InputEndpoints");
             // iterate through all of the various input endpoints and 
-            foreach (InputEndpoint inputEndpoint in _endpoints)
+            foreach (InputEndpoint inputEndpoint in Endpoints)
             {
                 inputEndpoints.Add(inputEndpoint.GetXmlTree());
             }

Elastacloud.AzureManagement.Fluent/Types/Virtual Machines/VmHost.cs

@@ -26,6 +26,6 @@ public class VmHost
         /// <summary>
         /// The internal endpoints referenced by this virtual machine
         /// </summary>
-        public InputEndpoints Endpoints { get; internal set; }
+        public IEnumerable<InputEndpoint> Endpoints { get; internal set; }
     }
 }