fixed a long-running bug which I never got round to earlier! This ensures that any async message failures generate a fluent exception

Author: azurecoder

Elastacloud.AzureManagement.Fluent/Commands/Services/GetAsyncStatusCommand.cs

@@ -11,7 +11,9 @@
 using System.IO;
 using System.Linq;
 using System.Net;
+using System.Xml;
 using System.Xml.Linq;
+using Elastacloud.AzureManagement.Fluent.Helpers;
 
 namespace Elastacloud.AzureManagement.Fluent.Commands.Services
 {
@@ -32,14 +34,33 @@ internal class GetAsyncStatusCommand : ServiceCommand
         /// <returns>An OperationStatus value</returns>
         internal OperationStatus GetOperationStatus()
         {
-            if (XmlResponsePayload == null)
-                throw new ApplicationException("unable to determine response for async operation");
-            XDocument document = XDocument.Parse(XmlResponsePayload, LoadOptions.None);
+            var document = GetXmlAsyncPayload();
             string services =
                 (from item in document.Descendants(QueryManager.BuildDefaultNamespaceXmlEntity("Operation"))
                  select (string) item.Element(QueryManager.BuildDefaultNamespaceXmlEntity("Status"))).FirstOrDefault();
             return (OperationStatus) Enum.Parse(typeof (OperationStatus), services);
         }
+        /// <summary>
+        /// Used to get the basic payload for the request in XML
+        /// </summary>
+        private XDocument GetXmlAsyncPayload()
+        {
+            if (XmlResponsePayload == null)
+                throw new ApplicationException("unable to determine response for async operation");
+            XDocument document = XDocument.Parse(XmlResponsePayload, LoadOptions.None);
+            return document;
+        }
+        /// <summary>
+        /// Used to get the failure text from an async request-response
+        /// </summary>
+        internal string GetFailureText()
+        {
+            var document = GetXmlAsyncPayload();
+            return document.Element(Namespaces.NsWindowsAzure + "Operation")
+                .Element(Namespaces.NsWindowsAzure + "Error")
+                .Element(Namespaces.NsWindowsAzure + "Message")
+                .Value;
+        }
 
         /// <summary>
         /// Gets the Xml payload from the response and releases the lock 

Elastacloud.AzureManagement.Fluent/Commands/Services/ServiceCommand.cs

@@ -16,6 +16,7 @@
 using System.Threading;
 using Elastacloud.AzureManagement.Fluent.Commands.Parsers;
 using Elastacloud.AzureManagement.Fluent.Helpers;
+using Elastacloud.AzureManagement.Fluent.Types.Exceptions;
 
 namespace Elastacloud.AzureManagement.Fluent.Commands.Services
 {
@@ -30,6 +31,7 @@ public class ServiceCommand : ICommand
         private static IQueryManager _queryManager;
         private string _subscriptionId;
         private WebException _exception;
+        private string _lastFailureResponse = null;
 
         #endregion
 
@@ -81,6 +83,7 @@ protected virtual void ResponseCallback(HttpWebResponse webResponse)
                         break;
                     case OperationStatus.Failed:
                         //Trace.WriteLine(String.Format("Hosted Service Response Id: {0}", MsftAsyncResponseId);
+                        _lastFailureResponse = asyncCommand.GetFailureText();
                         SitAndWait.Set();
                         return;
                     case OperationStatus.Succeeded:
@@ -267,10 +270,13 @@ public virtual void Execute()
                                                    RequestWithoutCertificate =
                                                        !(UseCertificate.HasValue && UseCertificate.Value)
                                                };
+
             CurrentQueryManager = CurrentQueryManager ?? new QueryManager();
             CurrentQueryManager.MakeASyncRequest(serviceManagementRequest, ResponseCallback, ErrorResponseCallback);
             // wait for up to 30 minutes - if a deployment takes longer than that ... it's probably HPC!
             SitAndWait.WaitOne(200000);
+            if(_lastFailureResponse != null)
+                throw new FluentManagementException(_lastFailureResponse, "ServiceCommand");
             if (_exception != null)
                 throw _exception;
         }

Elastacloud.FluentManagement.FSTest/VirtualMachines.fsx

@@ -56,5 +56,10 @@ let properties = new LinuxVirtualMachineProperties(
 vmClient.CreateNewVirtualMachineDeploymentFromTemplateGallery(
                                                               List<LinuxVirtualMachineProperties>([|properties|]),
                                                               "briskit1000")
-
+// test 1: Ensure that above contains no subnets when it's created and returns the address range + 1 ip
+// test 2: Receive events on state changes and ensure readyrole
+vmClient.LinuxVirtualMachineStatusEvent.Subscribe(fun vmstatus -> printfn "from %s to %s" (vmstatus.OldStatus.ToString()) (vmstatus.NewStatus.ToString()))
+// test 3: When created delete the subnet from the vnet - should generate a subnet busy exception of some sort
+let vnClient = VirtualNetworkClient(subscriptionId, (getFromBizsparkPlus subscriptionId))
+vnClient.RemoveSubnet("fsnet", "Subnet-3")
 let images = vmClient.GetCurrentUbuntuImage()