Fix for https://issues.sonatype.org/browse/AHC-96

("Setting url on RequestBuilder requires scheme to use // separator")

Author: jfarcand

src/main/java/com/ning/http/client/RequestBuilderBase.java

@@ -307,7 +307,19 @@ private String buildUrl(String url) {
         if (uri.getAuthority() != null) {
             buildedUrl.append(uri.getAuthority());
         }
-        buildedUrl.append(uri.getRawPath());
+        if (uri.getRawPath() != null) {
+            buildedUrl.append(uri.getRawPath());
+        } else {
+            // AHC-96
+            // Let's try to derive it
+            if (url.indexOf("://") == -1) {
+                String s = buildedUrl.toString();
+                url = s + url.substring(uri.getScheme().length() + 1);
+                return buildUrl(url);
+            } else {
+                throw new IllegalArgumentException("Invalid url " + uri.toString());
+            }
+        }
 
         if (uri.getRawQuery() != null && !uri.getRawQuery().equals("")) {
             String[] queries = uri.getRawQuery().split("&");

src/test/java/com/ning/http/client/async/AsyncProvidersBasicTest.java

@@ -1581,4 +1581,16 @@ public void headShouldNotAllowBody() throws IllegalArgumentException, IOExceptio
         builder.setBody("Boo!");
         builder.execute();
     }
+
+    protected String getBrokenTargetUrl() {
+        return String.format("http:127.0.0.1:%d/foo/test", port1);
+    }
+
+    @Test(groups = {"standalone", "default_provider"})
+    public void invalidUri() throws Exception {
+        AsyncHttpClient c = getAsyncHttpClient(null);
+        AsyncHttpClient.BoundRequestBuilder builder = c.prepareGet(getBrokenTargetUrl());
+        Response r = c.executeRequest(builder.build()).get();
+        assertEquals(200, r.getStatusCode());
+    }
 }