Skip to content

Commit cb37868

Browse files
authored
Revert "Fix setOptions method (#974)" (#1039)
This reverts commit 0918341.
1 parent c8b8a84 commit cb37868

File tree

2 files changed

+3
-21
lines changed

2 files changed

+3
-21
lines changed

src/PDF.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,13 @@ public function setOption($attribute, $value = null): self
156156
/**
157157
* Replace all the Options from DomPDF
158158
*
159+
* @deprecated Use setOption to override individual options.
159160
* @param array<string, mixed> $options
160161
*/
161162
public function setOptions(array $options): self
162163
{
163-
$dompdfOptions = new Options(app()->make('dompdf.options'));
164-
$dompdfOptions->set($options);
165-
$this->dompdf->setOptions($dompdfOptions);
164+
$options = new Options($options);
165+
$this->dompdf->setOptions($options);
166166
return $this;
167167
}
168168

tests/PdfTest.php

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -96,24 +96,6 @@ public function testSaveOnDisk(): void
9696
$this->assertEquals($content, $pdf->output());
9797
}
9898

99-
public function testConfigOptions(): void
100-
{
101-
\Config::set('dompdf.options.default_font', 'default_font');
102-
\Config::set('dompdf.options.log_output_file', 'default_log');
103-
104-
$pdf = Facade\Pdf::loadHtml('<h1>Test</h1>');
105-
$this->assertEquals('default_font', $pdf->getDomPDF()->getOptions()->getDefaultFont());
106-
$this->assertEquals('default_log', $pdf->getDomPDF()->getOptions()->getLogOutputFile());
107-
108-
$pdf->setOption('default_font', 'custom_font');
109-
$this->assertEquals('custom_font', $pdf->getDomPDF()->getOptions()->getDefaultFont());
110-
$this->assertEquals('default_log', $pdf->getDomPDF()->getOptions()->getLogOutputFile());
111-
112-
$pdf->setOptions([]); // reset options to config/dompdf.php
113-
$this->assertEquals('default_font', $pdf->getDomPDF()->getOptions()->getDefaultFont());
114-
$this->assertEquals('default_log', $pdf->getDomPDF()->getOptions()->getLogOutputFile());
115-
}
116-
11799
public function testMagicMethods(): void
118100
{
119101
$pdf = Facade\Pdf::setBaseHost('host')->setProtocol('protocol')

0 commit comments

Comments
 (0)