@@ -1700,7 +1700,7 @@ or refactoring an existing one.
17001700
17011701** Bad:**
17021702``` javascript
1703- const assert = require ( ' assert' ) ;
1703+ import assert from ' assert' ;
17041704
17051705describe (' MakeMomentJSGreatAgain' , () => {
17061706 it (' handles date boundaries' , () => {
@@ -1723,7 +1723,7 @@ describe('MakeMomentJSGreatAgain', () => {
17231723
17241724** Good:**
17251725``` javascript
1726- const assert = require ( ' assert' ) ;
1726+ import assert from ' assert' ;
17271727
17281728describe (' MakeMomentJSGreatAgain' , () => {
17291729 it (' handles 30-day months' , () => {
@@ -1754,11 +1754,14 @@ Promises are a built-in global type. Use them!
17541754
17551755** Bad:**
17561756``` javascript
1757- require (' request' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
1757+ import { get } from ' request' ;
1758+ import { writeFile } from ' fs' ;
1759+
1760+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
17581761 if (requestErr) {
17591762 console .error (requestErr);
17601763 } else {
1761- require ( ' fs ' ). writeFile (' article.html' , response .body , (writeErr ) => {
1764+ writeFile (' article.html' , response .body , (writeErr ) => {
17621765 if (writeErr) {
17631766 console .error (writeErr);
17641767 } else {
@@ -1772,9 +1775,12 @@ require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (req
17721775
17731776** Good:**
17741777``` javascript
1775- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1778+ import { get } from ' request' ;
1779+ import { writeFile } from ' fs' ;
1780+
1781+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
17761782 .then ((response ) => {
1777- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1783+ return writeFile (' article.html' , response);
17781784 })
17791785 .then (() => {
17801786 console .log (' File written' );
@@ -1795,9 +1801,12 @@ today!
17951801
17961802** Bad:**
17971803``` javascript
1798- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1804+ import { get } from ' request-promise' ;
1805+ import { writeFile } from ' fs-promise' ;
1806+
1807+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
17991808 .then ((response ) => {
1800- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1809+ return writeFile (' article.html' , response);
18011810 })
18021811 .then (() => {
18031812 console .log (' File written' );
@@ -1810,10 +1819,13 @@ require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Marti
18101819
18111820** Good:**
18121821``` javascript
1822+ import { get } from ' request-promise' ;
1823+ import { writeFile } from ' fs-promise' ;
1824+
18131825async function getCleanCodeArticle () {
18141826 try {
1815- const response = await require ( ' request-promise ' ). get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1816- await require ( ' fs-promise ' ). writeFile (' article.html' , response);
1827+ const response = await get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1828+ await writeFile (' article.html' , response);
18171829 console .log (' File written' );
18181830 } catch (err) {
18191831 console .error (err);
0 commit comments