Skip to content

Commit 26ff387

Browse files
committed
Update tests
1 parent 9d1451c commit 26ff387

File tree

2 files changed

+26
-19
lines changed

2 files changed

+26
-19
lines changed

package.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,21 @@
3232
"devDependencies": {
3333
"babel-cli": "^6.10.1",
3434
"babel-preset-es2015": "^6.9.0",
35+
"cross-env": "^1.0.8",
3536
"husky": "^0.11.4",
37+
"mkdirp": "^0.5.1",
3638
"mocha": "^2.2.4",
37-
"rimraf": "^2.4.1",
39+
"os-tmpdir": "^1.0.1",
40+
"rimraf": "^2.5.2",
3841
"server-ready": "^0.2.0",
3942
"standard": "^3.8.0",
40-
"supertest": "~0.8.1"
43+
"supertest": "~0.8.1",
44+
"temp-write": "^2.1.0"
4145
},
4246
"scripts": {
4347
"test": "npm run test:cli && npm run test:server && standard",
44-
"test:cli": "NODE_ENV=test mocha -R spec test/cli/*.js",
45-
"test:server": "NODE_ENV=test mocha -R spec test/server/*.js",
48+
"test:cli": "cross-env NODE_ENV=test mocha -R spec test/cli/*.js",
49+
"test:server": "cross-env NODE_ENV=test mocha -R spec test/server/*.js",
4650
"start": "node bin",
4751
"prepush": "npm t",
4852
"build": "babel src -d lib"

test/cli/index.js

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ var path = require('path')
33
var cp = require('child_process')
44
var assert = require('assert')
55
var supertest = require('supertest')
6-
var rmrf = require('rimraf')
6+
var osTmpdir = require('os-tmpdir')
7+
var tempWrite = require('temp-write')
8+
var mkdirp = require('mkdirp')
9+
var rimraf = require('rimraf')
710
var express = require('express')
811
var serverReady = require('server-ready')
912
var pkg = require('../../package.json')
1013

1114
var PORT = 3100
12-
var tmpDir = path.join(__dirname, '../../tmp')
13-
var dbFile = path.join(tmpDir, 'db.json')
14-
var routesFile = path.join(tmpDir, 'routes.json')
1515

1616
function cli (args) {
1717
var bin = path.join(__dirname, '../..', pkg.bin)
@@ -27,25 +27,26 @@ describe('cli', function () {
2727

2828
var child
2929
var request
30+
var dbFile
31+
var routesFile
3032

3133
beforeEach(function () {
32-
rmrf.sync(tmpDir)
33-
fs.mkdirSync(tmpDir)
34-
fs.writeFileSync(dbFile, JSON.stringify({
34+
dbFile = tempWrite.sync(JSON.stringify({
3535
posts: [
3636
{ id: 1 },
3737
{_id: 2 }
3838
]
39-
}))
40-
fs.writeFileSync(routesFile, JSON.stringify({
39+
}), 'db.json')
40+
41+
routesFile = tempWrite.sync(JSON.stringify({
4142
'/blog/': '/'
42-
}))
43+
}), 'routes.json')
44+
4345
++PORT
4446
request = supertest('http://localhost:' + PORT)
4547
})
4648

4749
afterEach(function () {
48-
rmrf.sync(tmpDir)
4950
child.kill()
5051
})
5152

@@ -148,13 +149,15 @@ describe('cli', function () {
148149

149150
})
150151

151-
describe('db.json -s fixtures/public -S ../../tmp', function () {
152+
describe('db.json -s fixtures/public -S /some/path/snapshots', function () {
152153

153-
var snapshotsDir = path.join(tmpDir, 'snapshots')
154+
var snapshotsDir = path.join(osTmpdir(), 'snapshots')
154155
var publicDir = 'fixtures/public'
155156

156157
beforeEach(function (done) {
157-
fs.mkdirSync(snapshotsDir)
158+
rimraf.sync(snapshotsDir)
159+
mkdirp.sync(snapshotsDir)
160+
158161
child = cli([dbFile, '-s', publicDir, '-S', snapshotsDir])
159162
serverReady(PORT, function () {
160163
child.stdin.write('s\n')
@@ -166,7 +169,7 @@ describe('cli', function () {
166169
request.get('/').expect(/Hello/, done)
167170
})
168171

169-
it('should save a snapshot in ../../tmp', function () {
172+
it('should save a snapshot in snapshots dir', function () {
170173
assert.equal(fs.readdirSync(snapshotsDir).length, 1)
171174
})
172175

0 commit comments

Comments
 (0)