Skip to content

Commit e37405f

Browse files
Paul LeclercqPaul Leclercq
Paul Leclercq
authored and
Paul Leclercq
committed
update progressBar
1 parent 2a44201 commit e37405f

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

app/js/_timer.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -271,15 +271,6 @@ var timerModule = angular.module('timer', [])
271271
$scope.millis = $scope.countdown * 1000;
272272
}
273273

274-
if(typeTimer !== null){
275-
//calculate progress bar
276-
$scope.progressBar = progressBarService.calculateProgressBar($scope.startTime, $scope.millis, $scope.endTime, $scope.countdownattr);
277-
278-
if($scope.progressBar === 100){
279-
$scope.displayProgressActive = ''; //No more Bootstrap active effect
280-
}
281-
}
282-
283274
if ($scope.millis < 0) {
284275
$scope.stop();
285276
$scope.millis = 0;
@@ -308,6 +299,15 @@ var timerModule = angular.module('timer', [])
308299
$scope.$eval($scope.finishCallback);
309300
}
310301
}
302+
303+
if(typeTimer !== null){
304+
//calculate progress bar
305+
$scope.progressBar = progressBarService.calculateProgressBar($scope.startTime, $scope.millis, $scope.endTime, $scope.countdownattr);
306+
307+
if($scope.progressBar === 100){
308+
$scope.displayProgressActive = ''; //No more Bootstrap active effect
309+
}
310+
}
311311
};
312312

313313
if ($scope.autoStart === undefined || $scope.autoStart === true) {

app/js/progressBarService.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ app.factory('progressBarService', function() {
3232
displayProgressBar = remainingTime * 100 / coutdown;
3333
}
3434

35-
if(typeof coutdown !== 'undefined') {
36-
console.log("$scope.countdownattr", coutdown);
37-
console.log("$scope.progressBar", displayProgressBar);
38-
console.log("$scope.remainingTime", remainingTime);
39-
}
4035
displayProgressBar = 100 - displayProgressBar; //To have 0 to 100 and not 100 to 0
4136
displayProgressBar = Math.round(displayProgressBar * 10) / 10; //learn more why : http://stackoverflow.com/questions/588004/is-floating-point-math-broken
4237

index.html

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,15 @@ <h3>
177177
on Progressbar control.</p>
178178
<code ng-non-bindable="">
179179
&lt;timer countdown=&quot;100&quot; interval=&quot;1000&quot;&gt;&lt;div class=&quot;progress
180-
progress-striped active {{displayProgressActive}}&quot;style="height: 30px;"&gt; &lt;div class=&quot;bar&quot; style=&quot;min-width: 2em;width: {{progressBar}}%;&quot;&gt;&lt;/div&gt;
180+
progress-striped active {{displayProgressActive}}&quot;style="height: 30px;"&gt;
181+
Remaining time : {{countdown}} second{{secondsS}} ({{progressBar}}%). Activity? {{displayProgressActive}}
182+
&lt;div class=&quot;bar&quot; style=&quot;min-width: 2em;width: {{progressBar}}%;&quot;&gt;&lt;/div&gt;
181183
&lt;/div&gt;&lt;/timer&gt;
182184
</code>
183185

184186
<h3>
185-
<timer interval="1000" countdown="30">
186-
Remaining time : {{countdown}}
187+
<timer id="countdown" interval="1000" countdown="30">
188+
Remaining time : {{countdown}} second{{secondsS}} ({{progressBar}}%). Activity? {{displayProgressActive}}
187189
<div class="progress progress-striped {{displayProgressActive}}" style="height: 30px;">
188190
<div class="bar" style="min-width: 2em; height: 30px; width: {{progressBar}}%;">
189191
{{ progressBar }}%
@@ -199,6 +201,7 @@ <h3>
199201
</code>
200202
<h3>
201203
<timer interval="1000" end-time="1451628000000">
204+
({{progressBar}}%). Progress bar activity : {{displayProgressActive}}
202205
<div class="progress progress-striped {{displayProgressActive}}" style="height: 30px;">
203206
<div class="bar" style="min-width: 2em; width: {{progressBar}}%;">
204207
{{ progressBar }}%</div>

0 commit comments

Comments
 (0)