Skip to content

Commit 1bd8403

Browse files
committed
refactored code
1 parent 913a735 commit 1bd8403

File tree

2 files changed

+7
-21
lines changed

2 files changed

+7
-21
lines changed

ep19-call-api-jquery/app/components/App.jsx

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,7 @@ export default class App extends React.Component {
2828
};
2929

3030
var markTaskDoneCallback = function(data){
31-
if(data.success){
32-
api.getTasks(processData.bind(this));
33-
} else {
34-
console.log("Failed to mark task as done/undone")
35-
}
31+
data.success ? api.getTasks(processData.bind(this)) : console.log("Failed to mark task as done/undone");
3632
};
3733

3834
api.markTaskDone(markTaskDoneCallback.bind(this), todo);
@@ -43,15 +39,11 @@ export default class App extends React.Component {
4339
this.setState({todos: data.todos});
4440
};
4541

46-
var markTaskDeleteCallback = function(data){
47-
if(data.success){
48-
api.getTasks(processData.bind(this));
49-
} else {
50-
console.log("Failed to delete task")
51-
}
42+
var deleteTaskCallback = function(data){
43+
data.success ? api.getTasks(processData.bind(this)) : console.log("Failed to delete task");
5244
};
5345

54-
api.deleteTask(markTaskDeleteCallback.bind(this), idToBeDeleted);
46+
api.deleteTask(deleteTaskCallback.bind(this), idToBeDeleted);
5547
}
5648

5749
handleSubmit (event) {
@@ -60,15 +52,11 @@ export default class App extends React.Component {
6052
var newTodo = { title: this.state.title, done: false };
6153

6254
var processData = function(data) {
63-
this.setState({todos: data.todos});
55+
this.setState({title: '', todos: data.todos});
6456
};
6557

6658
var addTaskCallback = function(data){
67-
if(data.success){
68-
api.getTasks(processData.bind(this));
69-
} else {
70-
console.log("Failed to delete task")
71-
}
59+
data.success ? api.getTasks(processData.bind(this)) : console.log("Failed to add task");
7260
};
7361

7462
api.addTask(addTaskCallback.bind(this), newTodo);

ep19-call-api-jquery/app/utils/api.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ var api = {
99

1010
markTaskDone (processData, todo) {
1111
var url = Constants.BASE_URL + 'todos/' + todo.id;
12-
var params = {
13-
done: todo.done
14-
};
12+
var params = { done: todo.done };
1513
this.makeAjaxCall(url, 'PUT', processData, params)
1614
},
1715

0 commit comments

Comments
 (0)