RequestBuilder.setUrl shouldn't accept an URI without a host, close AsyncHttpClient#571

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -388,8 +388,11 @@ public T setUrl(String url) {
     }
 
     public T setURI(URI uri) {
+        if (uri.getHost() == null)
+            throw new NullPointerException("uri.host");
         if (uri.getPath() == null)
-            throw new IllegalArgumentException("Unsupported uri format: " + uri);
+            throw new NullPointerException("uri.path");
+
         request.originalUri = uri;
         addQueryParameters(request.originalUri);
         request.uri = null;

api/src/test/java/org/asynchttpclient/async/AsyncProvidersBasicTest.java

@@ -386,15 +386,12 @@ public void onThrowable(Throwable t) {
         }
     }
 
-    @Test(groups = { "online", "default_provider", "async" })
+    @Test(groups = { "online", "default_provider", "async" }, expectedExceptions = { NullPointerException.class })
     public void asyncNullSchemeTest() throws Exception {
         AsyncHttpClient client = getAsyncHttpClient(null);
 
         try {
             client.prepareGet("www.sun.com").execute();
-            fail();
-        } catch (IllegalArgumentException ex) {
-            assertTrue(true);
         } finally {
             client.close();
         }
@@ -1555,7 +1552,7 @@ public void getShouldAllowBody() throws IllegalArgumentException, IOException {
         }
     }
 
-    @Test(groups = { "standalone", "default_provider" }, expectedExceptions = { IllegalArgumentException.class })
+    @Test(groups = { "standalone", "default_provider" }, expectedExceptions = { NullPointerException.class })
     public void invalidUri() throws Exception {
         AsyncHttpClient client = getAsyncHttpClient(null);
         try {