Multipart name should be optional, close AsyncHttpClient#523

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/multipart/Part.java

@@ -128,12 +128,11 @@ protected void visitStart(PartVisitor visitor, byte[] boundary) throws IOExcepti
     }
 
     protected void visitDispositionHeader(PartVisitor visitor) throws IOException {
-
+        visitor.withBytes(CRLF_BYTES);
+        visitor.withBytes(CONTENT_DISPOSITION_BYTES);
+        visitor.withBytes(getDispositionType() != null ? getDispositionType().getBytes(StandardCharsets.US_ASCII)
+                : FORM_DATA_DISPOSITION_TYPE_BYTES);
         if (getName() != null) {
-            visitor.withBytes(CRLF_BYTES);
-            visitor.withBytes(CONTENT_DISPOSITION_BYTES);
-            visitor.withBytes(getDispositionType() != null ? getDispositionType().getBytes(StandardCharsets.US_ASCII)
-                    : FORM_DATA_DISPOSITION_TYPE_BYTES);
             visitor.withBytes(NAME_BYTES);
             visitor.withBytes(QUOTE_BYTES);
             visitor.withBytes(getName().getBytes(StandardCharsets.US_ASCII));
@@ -239,14 +238,15 @@ public long length(byte[] boundary) {
         }
     }
 
-    /**
-     * Return a string representation of this object.
-     * 
-     * @return A string representation of this object.
-     * @see java.lang.Object#toString()
-     */
     public String toString() {
-        return this.getName();
+        return new StringBuilder()//
+                .append("name=").append(getName())//
+                .append(" contentType=").append(getContentType())//
+                .append(" charset=").append(getCharSet())//
+                .append(" tranferEncoding=").append(getTransferEncoding())//
+                .append(" contentId=").append(getContentId())//
+                .append(" dispositionType=").append(getDispositionType())//
+                .toString();
     }
 
     public abstract long write(WritableByteChannel target, byte[] boundary) throws IOException;

api/src/main/java/org/asynchttpclient/multipart/PartBase.java

@@ -47,17 +47,13 @@ public abstract class PartBase extends Part {
     /**
      * Constructor.
      * 
-     * @param name The name of the part
+     * @param name The name of the part, or <code>null</code>
      * @param contentType The content type, or <code>null</code>
      * @param charSet The character encoding, or <code>null</code>
      * @param transferEncoding The transfer encoding, or <code>null</code>
      * @param contentId The content id, or <code>null</code>
      */
     public PartBase(String name, String contentType, String charSet, String transferEncoding, String contentId) {
-
-        if (name == null) {
-            throw new NullPointerException("name");
-        }
         this.name = name;
         this.contentType = contentType;
         this.charSet = charSet;