Curse people setting public modifier on interface methods

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/AsyncHttpClientRegistry.java

@@ -79,3 +79,4 @@ public interface AsyncHttpClientRegistry {
 
     void clearAllInstances();
 }
+

api/src/main/java/org/asynchttpclient/AsyncHttpProviderConfig.java

@@ -29,28 +29,28 @@ public interface AsyncHttpProviderConfig<U, V> {
      * @param value the value of the property
      * @return this instance of AsyncHttpProviderConfig
      */
-    public AsyncHttpProviderConfig<U, V> addProperty(U name, V value);
+    AsyncHttpProviderConfig<U, V> addProperty(U name, V value);
 
     /**
      * Return the value associated with the property's name
      *
      * @param name
      * @return this instance of AsyncHttpProviderConfig
      */
-    public V getProperty(U name);
+    V getProperty(U name);
 
     /**
      * Remove the value associated with the property's name
      *
      * @param name
      * @return true if removed
      */
-    public V removeProperty(U name);
+    V removeProperty(U name);
 
     /**
      * Return the curent entry set.
      *
      * @return a the curent entry set.
      */
-    public Set<Map.Entry<U, V>> propertiesSet();
+    Set<Map.Entry<U, V>> propertiesSet();
 }

api/src/main/java/org/asynchttpclient/Body.java

@@ -44,5 +44,4 @@ public interface Body extends Closeable {
      * @throws IOException
      */
     void close() throws IOException;
-
 }

api/src/main/java/org/asynchttpclient/BodyConsumer.java

@@ -36,5 +36,4 @@ public interface BodyConsumer extends Closeable {
      * @throws IOException
      */
     void close() throws IOException;
-
 }

api/src/main/java/org/asynchttpclient/ProgressAsyncHandler.java

@@ -44,5 +44,4 @@ public interface ProgressAsyncHandler<T> extends AsyncHandler<T> {
      * @return a {@link AsyncHandler.STATE} telling to CONTINUE or ABORT the current processing.
      */
     STATE onContentWriteProgress(long amount, long current, long total);
-
 }

api/src/main/java/org/asynchttpclient/Request.java

@@ -44,43 +44,43 @@ public interface Request {
      *
      * @return the request's method name (GET, POST, etc.)
      */
-    public String getMethod();
+    String getMethod();
 
     /**
      * Return the decoded url
      *
      * @return the decoded url
      */
-    public String getUrl();
+    String getUrl();
 
-    public URI getOriginalURI();
+    URI getOriginalURI();
 
-    public URI getURI();
+    URI getURI();
 
-    public URI getRawURI();
+    URI getRawURI();
 
     /**
      * Return the InetAddress to override
      *
      * @return the InetAddress
      */
-    public InetAddress getInetAddress();
+    InetAddress getInetAddress();
 
-    public InetAddress getLocalAddress();
+    InetAddress getLocalAddress();
 
     /**
      * Return the undecoded url
      *
      * @return the undecoded url
      */
-    public String getRawUrl();
+    String getRawUrl();
 
     /**
      * Return the current set of Headers.
      *
      * @return a {@link FluentCaseInsensitiveStringsMap} contains headers.
      */
-    public FluentCaseInsensitiveStringsMap getHeaders();
+    FluentCaseInsensitiveStringsMap getHeaders();
 
     /**
      * @return return <code>true</code> if request headers have been added,
@@ -95,128 +95,129 @@ public interface Request {
      *
      * @return an unmodifiable Collection of Cookies
      */
-    public Collection<Cookie> getCookies();
+    Collection<Cookie> getCookies();
 
     /**
      * Return the current request's body as a byte array
      *
      * @return a byte array of the current request's body.
      */
-    public byte[] getByteData();
+    byte[] getByteData();
 
     /**
      * Return the current request's body as a string
      *
      * @return an String representation of the current request's body.
      */
-    public String getStringData();
+    String getStringData();
 
     /**
      * Return the current request's body as an InputStream
      *
      * @return an InputStream representation of the current request's body.
      */
-    public InputStream getStreamData();
+    InputStream getStreamData();
 
     /**
      * Return the current request's body generator.
      *
      * @return A generator for the request body.
      */
-    public BodyGenerator getBodyGenerator();
+    BodyGenerator getBodyGenerator();
 
     /**
      * Return the current size of the content-lenght header based on the body's size.
      *
      * @return the current size of the content-lenght header based on the body's size.
      */
-    public long getContentLength();
+    long getContentLength();
 
     /**
      * Return the current parameters.
      *
      * @return a {@link FluentStringsMap} of parameters.
      */
-    public FluentStringsMap getParams();
+    FluentStringsMap getParams();
 
     /**
      * Return the current {@link Part}
      *
      * @return the current {@link Part}
      */
-    public List<Part> getParts();
+    List<Part> getParts();
 
     /**
      * Return the virtual host value.
      *
      * @return the virtual host value.
      */
-    public String getVirtualHost();
+    String getVirtualHost();
 
     /**
      * Return the query params.
      *
      * @return {@link FluentStringsMap} of query string
      */
-    public FluentStringsMap getQueryParams();
+    FluentStringsMap getQueryParams();
 
     /**
      * Return the {@link ProxyServer}
      *
      * @return the {@link ProxyServer}
      */
-    public ProxyServer getProxyServer();
+    ProxyServer getProxyServer();
 
     /**
      * Return the {@link Realm}
      *
      * @return the {@link Realm}
      */
-    public Realm getRealm();
+    Realm getRealm();
 
     /**
      * Return the {@link File} to upload.
      *
      * @return the {@link File} to upload.
      */
-    public File getFile();
+    File getFile();
 
     /**
      * Return the <tt>true></tt> to follow redirect
      *
      * @return the <tt>true></tt> to follow redirect
      */
-    public boolean isRedirectEnabled();
+    boolean isRedirectEnabled();
 
     /**
      *
      * @return <tt>true></tt> if request's redirectEnabled setting
      *          should be used in place of client's
      */
-    public boolean isRedirectOverrideSet();
+    boolean isRedirectOverrideSet();
 
     /**
      * Return the request time out in milliseconds.
      *
      * @return requestTimeoutInMs.
      */
-    public int getRequestTimeoutInMs();
+    int getRequestTimeoutInMs();
 
     /**
      * Return the HTTP Range header value, or
      *
      * @return the range header value, or 0 is not set.
      */
-    public long getRangeOffset();
+    long getRangeOffset();
 
     /**
      * Return the encoding value used when encoding the request's body.
      *
      * @return the encoding value used when encoding the request's body.
      */
-    public String getBodyEncoding();
+    String getBodyEncoding();
 
-    public boolean isUseRawUrl();
+    boolean isUseRawUrl();
 
     ConnectionPoolKeyStrategy getConnectionPoolKeyStrategy();
 }
+

api/src/main/java/org/asynchttpclient/ResumableBodyConsumer.java

@@ -33,5 +33,4 @@ public interface ResumableBodyConsumer extends BodyConsumer {
      * @throws IOException
      */
     long getTransferredBytes() throws IOException;
-
 }

api/src/main/java/org/asynchttpclient/SignatureCalculator.java

@@ -35,5 +35,7 @@ public interface SignatureCalculator {
      * @param request        Request that is being built; needed to access content to
      *                       be signed
      */
-    public void calculateAndAddSignature(String url, Request request, RequestBuilderBase<?> requestBuilder);
+    void calculateAndAddSignature(String url,
+                                  Request request,
+                                  RequestBuilderBase<?> requestBuilder);
 }

api/src/main/java/org/asynchttpclient/ThrowableHandler.java

@@ -19,5 +19,4 @@
 public interface ThrowableHandler {
 
     void onThrowable(Throwable t);
-
 }

api/src/main/java/org/asynchttpclient/UpgradeHandler.java

@@ -33,5 +33,4 @@ public interface UpgradeHandler<T> {
      * @param t a {@link Throwable}
      */
     void onFailure(Throwable t);
-
 }

api/src/main/java/org/asynchttpclient/filter/IOExceptionFilter.java

@@ -25,5 +25,5 @@ public interface IOExceptionFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
-    public <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
+    <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
 }

api/src/main/java/org/asynchttpclient/filter/RequestFilter.java

@@ -26,5 +26,5 @@ public interface RequestFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
-    public <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
+    <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
 }

api/src/main/java/org/asynchttpclient/filter/ResponseFilter.java

@@ -29,5 +29,5 @@ public interface ResponseFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
-    public <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
+    <T> FilterContext<T> filter(FilterContext<T> ctx) throws FilterException;
 }

api/src/main/java/org/asynchttpclient/listener/TransferListener.java

@@ -24,19 +24,19 @@ public interface TransferListener {
     /**
      * Invoked when the request bytes are starting to get send.
      */
-    public void onRequestHeadersSent(FluentCaseInsensitiveStringsMap headers);
+    void onRequestHeadersSent(FluentCaseInsensitiveStringsMap headers);
 
     /**
      * Invoked when the response bytes are starting to get received.
      */
-    public void onResponseHeadersReceived(FluentCaseInsensitiveStringsMap headers);
+    void onResponseHeadersReceived(FluentCaseInsensitiveStringsMap headers);
 
     /**
      * Invoked every time response's chunk are received.
      *
      * @param bytes a {@link byte[]}
      */
-    public void onBytesReceived(byte[] bytes) throws IOException;
+    void onBytesReceived(byte[] bytes) throws IOException;
 
     /**
      * Invoked every time request's chunk are sent.
@@ -45,17 +45,18 @@ public interface TransferListener {
      * @param current The amount of bytes transferred
      * @param total   The total number of bytes transferred
      */
-    public void onBytesSent(long amount, long current, long total);
+    void onBytesSent(long amount, long current, long total);
 
     /**
      * Invoked when the response bytes are been fully received.
      */
-    public void onRequestResponseCompleted();
+    void onRequestResponseCompleted();
 
     /**
      * Invoked when there is an unexpected issue.
      *
      * @param t a {@link Throwable}
      */
-    public void onThrowable(Throwable t);
+    void onThrowable(Throwable t);
 }
+

api/src/main/java/org/asynchttpclient/resumable/ResumableAsyncHandler.java

@@ -254,29 +254,29 @@ public static interface ResumableProcessor {
          * @param key              a key. The recommended way is to use an url.
          * @param transferredBytes The number of bytes successfully transferred.
          */
-        public void put(String key, long transferredBytes);
+        void put(String key, long transferredBytes);
 
         /**
          * Remove the key associate value.
          *
          * @param key key from which the value will be discarded
          */
-        public void remove(String key);
+        void remove(String key);
 
         /**
          * Save the current {@link Map} instance which contains information about the current transfer state.
          * This method *only* invoked when the JVM is shutting down.
          *
          * @param map
          */
-        public void save(Map<String, Long> map);
+        void save(Map<String, Long> map);
 
         /**
          * Load the {@link Map} in memory, contains information about the transferred bytes.
          *
          * @return {@link Map}
          */
-        public Map<String, Long> load();
+        Map<String, Long> load();
 
     }