corrections

Author: sandeepmistry

examples/OBDII/EngineRPM/EngineRPM.ino

@@ -8,7 +8,7 @@ const bool useStandardAddressing = true;
 void setup() {
   Serial.begin(9600);
 
-  Serial.println("CAN OBD-II supported pids");
+  Serial.println("CAN OBD-II engine RPM");
 
   // start the CAN bus at 500 kbps
   if (!CAN.begin(500E3)) {
@@ -36,8 +36,9 @@ void loop() {
 
   // wait for response
   while (CAN.parsePacket() == 0 ||
-         CAN.read() != 0x41 ||                       // correct mode
-         CAN.read() != 0x0c);                        // correct PID
+         CAN.read() < 3 ||          // correct length
+         CAN.read() != 0x41 ||      // correct mode
+         CAN.read() != 0x0c);       // correct PID
 
   float rpm = ((CAN.read() * 256.0) + CAN.read()) / 4.0;
 

examples/OBDII/SupportedPIDs/SupportedPIDs.ino

@@ -32,7 +32,7 @@ void loop() {
     }
     CAN.write(0x02); // number of additional bytes
     CAN.write(0x01); // show current data
-    CAN.write(pid); // PID
+    CAN.write(pid);  // PID
     CAN.endPacket();
 
     // wait for response
@@ -66,5 +66,7 @@ void loop() {
     }
   }
 
+  Serial.println("That's all folks!");
+
   while (1); // all done
 }

examples/OBDII/VINReader/VINReader.ino

@@ -47,26 +47,28 @@ void loop() {
     Serial.write((char)CAN.read());
   }
 
-  // send the request for the remaining bytes
-  if (useStandardAddressing) {
-    CAN.beginPacket(0x7e0, 8);
-  } else {
-    CAN.beginExtendedPacket(0x18db10f1, 8); // TODO - verify this
-  }
-  CAN.write(0x30);
-  CAN.endPacket();
-
-  // read in remaining bytes
+  // read in remaining chunks
   for (int i = 0; i < 2; i++) {
+    // send the request for the next chunk
+    if (useStandardAddressing) {
+      CAN.beginPacket(0x7e0, 8);
+    } else {
+      CAN.beginExtendedPacket(0x18db33f1, 8);
+    }
+    CAN.write(0x30);
+    CAN.endPacket();
+
     // wait for response
-    while (CAN.parsePacket() == 0 ||                 // wait for response
-           CAN.read() != 0x21);
+    while (CAN.parsePacket() == 0 ||
+           CAN.read() != (0x21 + i)); // correct sequence number
 
     // print out
     while (CAN.available()) {
       Serial.write((char)CAN.read());
     }
   }
 
+  Serial.println("That's all folks!");
+
   while (1); // all done
 }