Fixed up the behavior of joining table transformation provider extensions to be consistent with the existing migrations in some of our apps (i.e. removing common words is applied when generating foreign keys, but not primary keys for joining tables). At some point we will "reset" the clock on these projects migrations so we can abandon these hacks (i.e. for the next major version start from a single migration to create everything, and require customers upgrading products from older versions to upgrade to the second to last version, prior to upgrading to the next major version).

Author: bittercoder

src/Migrator.Framework/JoiningTableTransformationProviderExtensions.cs

@@ -28,8 +28,7 @@ static string GetNameOfJoiningTable(string lhsTableName, string rhsTableName)
 			return (Inflector.Singularize(lhsTableName) ?? lhsTableName) + (Inflector.Pluralize(rhsTableName) ?? rhsTableName);
 		}
 
-		public static ITransformationProvider AddManyToManyJoiningTable(this ITransformationProvider database, string schema, string lhsTableName, string lhsKey, string rhsTableName, string rhsKey,
-																																		string joiningTableName)
+		public static ITransformationProvider AddManyToManyJoiningTable(this ITransformationProvider database, string schema, string lhsTableName, string lhsKey, string rhsTableName, string rhsKey, string joiningTableName)
 		{
 			string joiningTableWithSchema = TransformationProviderUtility.FormatTableName(schema, joiningTableName);
 
@@ -60,7 +59,7 @@ public static ITransformationProvider AddManyToManyJoiningTable(this ITransforma
 
 		static string ShortenKeyNameToBeSuitableForOracle(string pkName)
 		{
-			return TransformationProviderUtility.AdjustNameToSize(pkName, TransformationProviderUtility.MaxLengthForForeignKeyInOracle);
+			return TransformationProviderUtility.AdjustNameToSize(pkName, TransformationProviderUtility.MaxLengthForForeignKeyInOracle, false);
 		}
 
 		public static ITransformationProvider RemoveManyToManyJoiningTable(this ITransformationProvider database, string schema, string lhsTableName, string rhsTableName)

src/Migrator.Framework/Support/TransformationProviderUtility.cs

@@ -6,23 +6,24 @@ public static class TransformationProviderUtility
 	{
 		public const int MaxLengthForForeignKeyInOracle = 30;
 		static readonly ILog log = LogManager.GetLogger(typeof (TransformationProviderUtility));
+		static readonly string[] CommonWords = new[] {"Test"};
 
 		public static string CreateForeignKeyName(string tableName, string foreignKeyTableName)
 		{
 			string fkName = string.Format("FK_{0}_{1}", tableName, foreignKeyTableName);
 
-			return AdjustNameToSize(fkName, MaxLengthForForeignKeyInOracle);
+			return AdjustNameToSize(fkName, MaxLengthForForeignKeyInOracle, true);
 		}
 
-		public static string AdjustNameToSize(string name, int totalCharacters)
+		public static string AdjustNameToSize(string name, int totalCharacters, bool removeCommmonWords)
 		{
 			string adjustedName = name;
 
 			if (adjustedName.Length > totalCharacters)
 			{
-				if (adjustedName.Contains("Test"))
+				if (removeCommmonWords)
 				{
-					adjustedName = adjustedName.Replace("Test", "");
+					adjustedName = RemoveCommonWords(adjustedName);					
 				}
 			}
 
@@ -36,6 +37,18 @@ public static string AdjustNameToSize(string name, int totalCharacters)
 			return adjustedName;
 		}
 
+		static string RemoveCommonWords(string adjustedName)
+		{
+			foreach (var word in CommonWords)
+			{
+				if (adjustedName.Contains(word))
+				{
+					adjustedName = adjustedName.Replace(word, string.Empty);
+				}
+			}
+			return adjustedName;
+		}
+
 		public static string FormatTableName(string schema, string tableName)
 		{
 			return string.IsNullOrEmpty(schema) ? tableName : string.Format("{0}.{1}", schema, tableName);

src/Migrator.Providers/Impl/Oracle/OracleTransformationProvider.cs

@@ -263,14 +263,6 @@ public override void AddTable(string name, params Column[] columns)
 			base.AddTable(name, columns);
 		}
 
-		public override string Encode(Guid guid)
-		{
-			byte[] bytes = guid.ToByteArray();
-			var hex = new StringBuilder(bytes.Length * 2);
-			foreach (byte b in bytes) hex.AppendFormat("{0:X2}", b);
-			return hex.ToString();
-		}
-
 		void GuardAgainstMaximumColumnNameLengthForOracle(string name, Column[] columns)
 		{
 			foreach (Column column in columns)
@@ -283,5 +275,13 @@ void GuardAgainstMaximumColumnNameLengthForOracle(string name, Column[] columns)
 				}
 			}
 		}
+
+		public override string Encode(Guid guid)
+		{
+			byte[] bytes = guid.ToByteArray();
+			var hex = new StringBuilder(bytes.Length*2);
+			foreach (byte b in bytes) hex.AppendFormat("{0:X2}", b);
+			return hex.ToString();
+		}
 	}
 }