File tree Expand file tree Collapse file tree 1 file changed +6
-3
lines changed Expand file tree Collapse file tree 1 file changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -11,8 +11,11 @@ Someone with committer access will do the rest.
1111We have automated the process for merging pull requests into master. Our goal is to minimize the disruption for
1212Angular committers and also prevent breakages on master.
1313
14- When a PR is ready to merge, a project member in the CoreTeamMember list (see below) can add the special label,
15- ` PR: merge ` .
14+ When a PR has ` pr_state: LGTM ` and is ready to merge, you should add the ` pr_action: merge ` label.
15+ Currently (late 2015), we need to ensure that each PR will cleanly merge into the Google-internal version control,
16+ so the caretaker reviews the changes manually.
17+
18+ After this review, the caretaker adds ` zomg_admin: do_merge ` which is restricted to admins only.
1619A robot running as [ mary-poppins] ( https://github.com/mary-poppins )
1720is notified that the label was added by an authorized person,
1821and will create a new branch in the angular project, using the convention ` presubmit-{username}-pr-{number} ` .
@@ -26,6 +29,6 @@ Finally, after merge `mary-poppins` removes the presubmit branch.
2629
2730## Administration
2831
29- The list of users who can trigger a merge by adding the label is stored in our appengine app datastore.
32+ The list of users who can trigger a merge by adding the ` zomg_admin: do_merge ` label is stored in our appengine app datastore.
3033Edit the contents of the [ CoreTeamMember Table] (
3134https://console.developers.google.com/project/angular2-automation/datastore/query?queryType=KindQuery&namespace=&kind=CoreTeamMember )
You can’t perform that action at this time.
0 commit comments