Fixed a bug using proxies with the JDK API, found by DanielAdolfsson

Martin Korinth · Martin Korinth · commit 736f25763e9b · 2013-07-02T16:07:16.000+02:00
diff --git a/api/src/main/java/org/asynchttpclient/providers/jdk/JDKAsyncHttpProvider.java b/api/src/main/java/org/asynchttpclient/providers/jdk/JDKAsyncHttpProvider.java
@@ -173,12 +173,8 @@ private HttpURLConnection createUrlConnection(Request request) throws IOExceptio
             }
         }
 
-        HttpURLConnection urlConnection = null;
-        if (proxy == null) {
-            urlConnection = (HttpURLConnection) request.getURI().toURL().openConnection(Proxy.NO_PROXY);
-        } else {
-            urlConnection = (HttpURLConnection) proxyServer.getURI().toURL().openConnection(proxy);
-        }
+        HttpURLConnection urlConnection = (HttpURLConnection)
+            request.getURI().toURL().openConnection(proxy == null ? Proxy.NO_PROXY : proxy);
 
         if (request.getUrl().startsWith("https")) {
             HttpsURLConnection secure = (HttpsURLConnection) urlConnection;

Original file line number	Diff line number	Diff line change
`@@ -173,12 +173,8 @@ private HttpURLConnection createUrlConnection(Request request) throws IOExceptio`
`173`	`173`	`}`
`174`	`174`	`}`
`175`	`175`
`176`		`- HttpURLConnection urlConnection = null;`
`177`		`- if (proxy == null) {`
`178`		`- urlConnection = (HttpURLConnection) request.getURI().toURL().openConnection(Proxy.NO_PROXY);`
`179`		`- } else {`
`180`		`- urlConnection = (HttpURLConnection) proxyServer.getURI().toURL().openConnection(proxy);`
`181`		`- }`
	`176`	`+ HttpURLConnection urlConnection = (HttpURLConnection)`
	`177`	`+ request.getURI().toURL().openConnection(proxy == null ? Proxy.NO_PROXY : proxy);`
`182`	`178`
`183`	`179`	`if (request.getUrl().startsWith("https")) {`
`184`	`180`	`HttpsURLConnection secure = (HttpsURLConnection) urlConnection;`