Skip to content

Commit daa2219

Browse files
committed
Handle unnamed exception with contextlib.suppress
1 parent 27115a8 commit daa2219

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

patterns/behavioral/observer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@
88
Django Signals: https://docs.djangoproject.com/en/3.1/topics/signals/
99
Flask Signals: https://flask.palletsprojects.com/en/1.1.x/signals/
1010
"""
11+
1112
from __future__ import annotations
1213

14+
from contextlib import suppress
1315
from typing import List, Optional, Protocol
1416

1517

@@ -28,10 +30,8 @@ def attach(self, observer: Observer) -> None:
2830
self._observers.append(observer)
2931

3032
def detach(self, observer: Observer) -> None:
31-
try:
33+
with suppress(ValueError):
3234
self._observers.remove(observer)
33-
except ValueError:
34-
pass
3535

3636
def notify(self, modifier: Optional[Observer] = None) -> None:
3737
for observer in self._observers:

0 commit comments

Comments
 (0)