Skip to content

Commit 7a6292c

Browse files
authored
Merge pull request #1510 from supabase/master
[pull] master from supabase:master
2 parents b0e830a + d75b7c3 commit 7a6292c

File tree

11 files changed

+277
-267
lines changed

11 files changed

+277
-267
lines changed

.github/workflows/docs-lint-v2.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
env:
6464
BASE_REF: ${{ github.base_ref }}
6565
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
66-
BRANCH_NAME: ${{ github.head_ref }}
66+
PR_NUMBER: ${{ github.event.pull_request.number }}
6767
run: |
6868
set -o pipefail
6969
run_lints() {
@@ -76,6 +76,6 @@ jobs:
7676
LINT_EXIT_CODE=$?
7777
set -e
7878
if [[ $LINT_EXIT_CODE -ne 0 ]]; then
79-
gh pr comment "$BRANCH_NAME" --body "$LINT_RESULTS"
79+
gh pr comment "$PR_NUMBER" --body "$LINT_RESULTS"
8080
exit 1
8181
fi

apps/studio/components/interfaces/Auth/RateLimits/RateLimits.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,14 @@ import { toast } from 'sonner'
77
import * as z from 'zod'
88

99
import { useParams } from 'common'
10+
import { ScaffoldSection } from 'components/layouts/Scaffold'
1011
import AlertError from 'components/ui/AlertError'
1112
import NoPermission from 'components/ui/NoPermission'
1213
import { GenericSkeletonLoader } from 'components/ui/ShimmeringLoader'
1314
import { useAuthConfigQuery } from 'data/auth/auth-config-query'
1415
import { useAuthConfigUpdateMutation } from 'data/auth/auth-config-update-mutation'
1516
import { useCheckPermissions } from 'hooks/misc/useCheckPermissions'
1617
import {
17-
AlertDescription_Shadcn_,
18-
AlertTitle_Shadcn_,
19-
Alert_Shadcn_,
2018
Button,
2119
Card,
2220
CardContent,
@@ -25,14 +23,12 @@ import {
2523
FormField_Shadcn_,
2624
Form_Shadcn_,
2725
Input_Shadcn_,
28-
WarningIcon,
2926
Tooltip,
3027
TooltipContent,
3128
TooltipTrigger,
3229
} from 'ui'
3330
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
3431
import { isSmtpEnabled } from '../SmtpForm/SmtpForm.utils'
35-
import { ScaffoldSection } from 'components/layouts/Scaffold'
3632

3733
const RateLimits = () => {
3834
const { ref: projectRef } = useParams()
@@ -199,7 +195,7 @@ const RateLimits = () => {
199195
</p>
200196
<div className="mt-3">
201197
<Button asChild type="default" size="tiny">
202-
<Link href={`/project/${projectRef}/settings/auth`}>
198+
<Link href={`/project/${projectRef}/auth/smtp`}>
203199
View SMTP settings
204200
</Link>
205201
</Button>
@@ -375,7 +371,7 @@ const RateLimits = () => {
375371
<p className="mt-1">Enable anonymous logins to update this rate limit</p>
376372
<div className="mt-3">
377373
<Button asChild type="default" size="tiny">
378-
<Link href={`/project/${projectRef}/settings/auth`}>
374+
<Link href={`/project/${projectRef}/auth/providers`}>
379375
View auth settings
380376
</Link>
381377
</Button>

apps/studio/components/interfaces/Linter/Linter.utils.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ export const lintInfoMap: LintInfo[] = [
240240
name: 'password_requirements_min_length',
241241
title: 'Minimum password length not set or inadequate',
242242
icon: <Ruler className="text-foreground-muted" size={15} strokeWidth={1} />,
243-
link: ({ projectRef }) => `/project/${projectRef}/settings/auth`,
243+
link: ({ projectRef }) => `/project/${projectRef}/auth/providers?provider=Email`,
244244
linkText: 'View settings',
245245
docsLink: 'https://supabase.com/docs/guides/platform/going-into-prod#security',
246246
category: 'security',
@@ -258,7 +258,7 @@ export const lintInfoMap: LintInfo[] = [
258258
name: 'auth_leaked_password_protection',
259259
title: 'Leaked Password Protection Disabled',
260260
icon: <LockIcon className="text-foreground-muted" size={15} strokeWidth={1} />,
261-
link: ({ projectRef }) => `/project/${projectRef}/settings/auth`,
261+
link: ({ projectRef }) => `/project/${projectRef}/auth/providers?provider=Email`,
262262
linkText: 'View settings',
263263
docsLink:
264264
'https://supabase.com/docs/guides/auth/password-security#password-strength-and-leaked-password-protection',
@@ -268,7 +268,7 @@ export const lintInfoMap: LintInfo[] = [
268268
name: 'auth_insufficient_mfa_options',
269269
title: 'Insufficient MFA Options',
270270
icon: <LockIcon className="text-foreground-muted" size={15} strokeWidth={1} />,
271-
link: ({ projectRef }) => `/project/${projectRef}/settings/auth`,
271+
link: ({ projectRef }) => `/project/${projectRef}/auth/mfa`,
272272
linkText: 'View settings',
273273
docsLink: 'https://supabase.com/docs/guides/auth/auth-mfa',
274274
category: 'security',
@@ -277,7 +277,7 @@ export const lintInfoMap: LintInfo[] = [
277277
name: 'auth_password_policy_missing',
278278
title: 'Password Policy Missing',
279279
icon: <LockIcon className="text-foreground-muted" size={15} strokeWidth={1} />,
280-
link: ({ projectRef }) => `/project/${projectRef}/settings/auth`,
280+
link: ({ projectRef }) => `/project/${projectRef}/auth/providers?provider=Email`,
281281
linkText: 'View settings',
282282
docsLink: 'https://supabase.com/docs/guides/auth/password-security',
283283
category: 'security',
@@ -295,7 +295,7 @@ export const lintInfoMap: LintInfo[] = [
295295
name: 'no_backup_admin',
296296
title: 'No Backup Admin Detected',
297297
icon: <LockIcon className="text-foreground-muted" size={15} strokeWidth={1} />,
298-
link: ({ projectRef }) => `/project/${projectRef}/settings/auth`,
298+
link: ({ projectRef }) => `/project/${projectRef}/auth/mfa`,
299299
linkText: 'View settings',
300300
docsLink: 'https://supabase.com/docs/guides/auth/auth-mfa',
301301
category: 'security',

0 commit comments

Comments
 (0)