Skip to content

Commit 9dbb72c

Browse files
committed
JDKProvider's HostnameVerifier is null when enabling acceptAnyCertificate
1 parent 2501534 commit 9dbb72c

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

src/main/java/com/ning/http/client/AsyncHttpClientConfig.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import javax.net.ssl.HostnameVerifier;
2727
import javax.net.ssl.SSLContext;
28+
import javax.net.ssl.SSLSession;
2829

2930
import java.util.Collections;
3031
import java.util.LinkedList;
@@ -385,10 +386,15 @@ public boolean isValid() {
385386
* @return the {@link HostnameVerifier}
386387
*/
387388
public HostnameVerifier getHostnameVerifier() {
388-
if (hostnameVerifier == null && !acceptAnyCertificate) {
389-
synchronized(this) {
389+
if (hostnameVerifier == null) {
390+
synchronized (this) {
390391
if (hostnameVerifier == null)
391-
hostnameVerifier = new DefaultHostnameVerifier();
392+
hostnameVerifier = acceptAnyCertificate ? new HostnameVerifier() {
393+
@Override
394+
public boolean verify(String hostname, SSLSession session) {
395+
return true;
396+
}
397+
} : new DefaultHostnameVerifier();
392398
}
393399
}
394400
return hostnameVerifier;
@@ -926,12 +932,12 @@ public Builder setSslSessionCacheSize(Integer sslSessionCacheSize) {
926932
this.sslSessionCacheSize = sslSessionCacheSize;
927933
return this;
928934
}
929-
935+
930936
public Builder setSslSessionTimeout(Integer sslSessionTimeout) {
931937
this.sslSessionTimeout = sslSessionTimeout;
932938
return this;
933939
}
934-
940+
935941
/**
936942
* Create a config builder with values taken from the given prototype configuration.
937943
*

0 commit comments

Comments
 (0)