Check compiler using CMAKE_CXX_COMPILER_ID

mrjoel · mrjoel · commit 30eb5ce128d4 · 2020-04-28T15:21:16.000-06:00
Since the introduction of CMAKE_COMPILER_IS_GNUCXX CMake has
suggested using CMAKE_CXX_COMPILER_ID for more general checks.
diff --git a/src/lib_json/CMakeLists.txt b/src/lib_json/CMakeLists.txt
@@ -1,4 +1,4 @@
-if(CMAKE_COMPILER_IS_GNUCXX)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     #Get compiler version.
     execute_process(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
         OUTPUT_VARIABLE GNUCXX_VERSION

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-if(CMAKE_COMPILER_IS_GNUCXX)`
	`1`	`+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")`
`2`	`2`	`#Get compiler version.`
`3`	`3`	`execute_process(COMMAND ${CMAKE_CXX_COMPILER} -dumpversion`
`4`	`4`	`OUTPUT_VARIABLE GNUCXX_VERSION`