Update default enabled cipher suites, close AsyncHttpClient#1258

Author: slandelle

client/src/main/java/io/netty/handler/ssl/NettySslPackageAccessor.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) 2016 AsyncHttpClient Project. All rights reserved.
+ *
+ * This program is licensed to you under the Apache License Version 2.0,
+ * and you may not use this file except in compliance with the Apache License Version 2.0.
+ * You may obtain a copy of the Apache License Version 2.0 at
+ *     http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the Apache License Version 2.0 is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the Apache License Version 2.0 for the specific language governing permissions and limitations there under.
+ */
+package io.netty.handler.ssl;
+
+import java.util.Set;
+
+public final class NettySslPackageAccessor {
+
+    private NettySslPackageAccessor() {
+    }
+    
+    public static Set<String> jdkSupportedCipherSuites() {
+        return JdkSslContext.SUPPORTED_CIPHERS;
+    }
+}

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -623,7 +623,7 @@ public static class Builder {
         private boolean acceptAnyCertificate = defaultAcceptAnyCertificate();
         private int handshakeTimeout = defaultHandshakeTimeout();
         private String[] enabledProtocols = defaultEnabledProtocols();
-        private String[] enabledCipherSuites;
+        private String[] enabledCipherSuites = defaultEnabledCipherSuites();
         private int sslSessionCacheSize = defaultSslSessionCacheSize();
         private int sslSessionTimeout = defaultSslSessionTimeout();
         private SslContext sslContext;

client/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigDefaults.java

@@ -12,6 +12,11 @@
  */
 package org.asynchttpclient.config;
 
+import io.netty.handler.ssl.NettySslPackageAccessor;
+
+import java.util.Arrays;
+import java.util.Set;
+
 public final class AsyncHttpClientConfigDefaults {
 
     private AsyncHttpClientConfigDefaults() {
@@ -74,6 +79,12 @@ public static String defaultUserAgent() {
     public static String[] defaultEnabledProtocols() {
         return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getStringArray(ASYNC_CLIENT_CONFIG_ROOT + "enabledProtocols");
     }
+    
+    public static String[] defaultEnabledCipherSuites() {
+        String[] defaultEnabledCipherSuites = AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getStringArray(ASYNC_CLIENT_CONFIG_ROOT + "enabledCipherSuites");
+        Set<String> supportedCipherSuites = NettySslPackageAccessor.jdkSupportedCipherSuites();
+        return Arrays.stream(defaultEnabledCipherSuites).filter(supportedCipherSuites::contains).toArray(String[]::new);
+    }
 
     public static boolean defaultUseProxySelector() {
         return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getBoolean(ASYNC_CLIENT_CONFIG_ROOT + "useProxySelector");

client/src/main/resources/ahc-default.properties

@@ -12,6 +12,7 @@ org.asynchttpclient.maxRedirects=5
 org.asynchttpclient.compressionEnforced=false
 org.asynchttpclient.userAgent=AHC/2.0
 org.asynchttpclient.enabledProtocols=TLSv1.2, TLSv1.1, TLSv1
+org.asynchttpclient.enabledCipherSuites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA, TLS_RSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
 org.asynchttpclient.useProxySelector=false
 org.asynchttpclient.useProxyProperties=false
 org.asynchttpclient.validateResponseHeaders=true