Add a run-tests script which runs unit tests and pyflakes both.

Fix pyflakes warnings.

Author: dobey

HACKING

@@ -30,9 +30,11 @@ Running Tests
 Tests are run using `test_suite` from setuptools and rely on the mock and 
 bzrlib.tests packages. So you must install the 'python-setuptools,'
 'python-mock', and `python-bzrlib.tests` packages in order to run the tests.
-Once done, from the top of the repository you can run:
+Tarmac also uses 'pyflakes' to do static code checking. You will need to
+install the 'pyflakes' package as well, to ensure your changes do not report
+any new warnings. Once done, from the top of the repository you can run:
 
-% ./setup.py test
+% ./run-tests
 
 =============
 Writing Tests

run-tests

@@ -0,0 +1,23 @@
+#!/bin/bash
+#
+# Copyright 2010-2013 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+set -e -x
+
+# Run the tests
+python ./setup.py build test clean
+
+# Run the style checks
+pyflakes bin tarmac setup.py
+

tarmac/tests/test_log.py

@@ -18,7 +18,6 @@
 '''Tests for tarmac.log'''
 import cStringIO
 import os
-import shutil
 import sys
 
 from tarmac.tests import TarmacTestCase

tarmac/tests/test_plugin.py

@@ -16,6 +16,7 @@
 import os
 
 from mock import ANY, patch
+from operator import setitem
 from tarmac import plugin
 from tarmac import plugins as _mod_plugins
 from tarmac.tests import TarmacTestCase