Skip to content

Commit dc62f81

Browse files
committed
fix hashcompat deprecation warnings with django 1.5
1 parent aeb45f2 commit dc62f81

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

debug_toolbar/utils/tracking/db.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,16 @@
77
from django.template import Node
88
from django.utils import simplejson
99
from django.utils.encoding import force_unicode, smart_str
10-
from django.utils.hashcompat import sha_constructor
1110

1211
from debug_toolbar.utils import ms_from_timedelta, tidy_stacktrace, \
1312
get_template_info, get_stack
1413
from debug_toolbar.utils.compat.db import connections
14+
15+
try:
16+
from hashlib import sha1
17+
except ImportError:
18+
from django.utils.hashcompat import sha_constructor as sha1
19+
1520
# TODO:This should be set in the toolbar loader as a default and panels should
1621
# get a copy of the toolbar object with access to its config dictionary
1722
SQL_WARNING_THRESHOLD = getattr(settings, 'DEBUG_TOOLBAR_CONFIG', {}) \
@@ -134,7 +139,7 @@ def execute(self, sql, params=()):
134139
'duration': duration,
135140
'raw_sql': sql,
136141
'params': _params,
137-
'hash': sha_constructor(settings.SECRET_KEY \
142+
'hash': sha1(settings.SECRET_KEY \
138143
+ smart_str(sql) \
139144
+ _params).hexdigest(),
140145
'stacktrace': stacktrace,

debug_toolbar/views.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,14 @@
1010
from django.http import HttpResponseBadRequest
1111
from django.shortcuts import render_to_response
1212
from django.utils import simplejson
13-
from django.utils.hashcompat import sha_constructor
1413

1514
from debug_toolbar.utils.compat.db import connections
1615

16+
try:
17+
from hashlib import sha1
18+
except ImportError:
19+
from django.utils.hashcompat import sha_constructor as sha1
20+
1721

1822
class InvalidSQLError(Exception):
1923
def __init__(self, value):
@@ -37,7 +41,7 @@ def sql_select(request):
3741
sql = request.GET.get('sql', '')
3842
params = request.GET.get('params', '')
3943
alias = request.GET.get('alias', 'default')
40-
hash = sha_constructor(settings.SECRET_KEY + sql + params).hexdigest()
44+
hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
4145
if hash != request.GET.get('hash', ''):
4246
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
4347
if sql.lower().strip().startswith('select'):
@@ -72,7 +76,7 @@ def sql_explain(request):
7276
sql = request.GET.get('sql', '')
7377
params = request.GET.get('params', '')
7478
alias = request.GET.get('alias', 'default')
75-
hash = sha_constructor(settings.SECRET_KEY + sql + params).hexdigest()
79+
hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
7680
if hash != request.GET.get('hash', ''):
7781
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
7882
if sql.lower().strip().startswith('select'):
@@ -118,7 +122,7 @@ def sql_profile(request):
118122
sql = request.GET.get('sql', '')
119123
params = request.GET.get('params', '')
120124
alias = request.GET.get('alias', 'default')
121-
hash = sha_constructor(settings.SECRET_KEY + sql + params).hexdigest()
125+
hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
122126
if hash != request.GET.get('hash', ''):
123127
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
124128
if sql.lower().strip().startswith('select'):

0 commit comments

Comments
 (0)