Add PasswordsController tests for the authentication generator (rails#53255)

* Add PasswordsController tests for the authentication generator

* Fix style and presentation

* Add assert_notice helper

---------

Co-authored-by: David Heinemeier Hansson <[email protected]>

Author: codergeek121

railties/lib/rails/generators/test_unit/authentication/authentication_generator.rb

@@ -9,6 +9,10 @@ def create_user_test_files
         template "test/fixtures/users.yml"
         template "test/models/user_test.rb"
       end
+
+      def create_controller_test_files
+        template "test/controllers/passwords_controller_test.rb"
+      end
     end
   end
 end

railties/lib/rails/generators/test_unit/authentication/templates/test/controllers/passwords_controller_test.rb.tt

@@ -0,0 +1,67 @@
+require "test_helper"
+
+class PasswordsControllerTest < ActionDispatch::IntegrationTest
+  setup { @user = User.take }
+
+  test "new" do
+    get new_password_path
+    assert_response :success
+  end
+
+  test "create" do
+    post passwords_path, params: { email_address: @user.email_address }
+    assert_enqueued_email_with PasswordsMailer, :reset, args: [ @user ]
+    assert_redirected_to new_session_path
+
+    follow_redirect!
+    assert_notice "reset instructions sent"
+  end
+
+  test "create for an unknown user redirects but sends no mail" do
+    post passwords_path, params: { email_address: "[email protected]" }
+    assert_enqueued_emails 0
+    assert_redirected_to new_session_path
+
+    follow_redirect!
+    assert_notice "reset instructions sent"
+  end
+
+  test "edit" do
+    get edit_password_path(@user.password_reset_token)
+    assert_response :success
+  end
+
+  test "edit with invalid password reset token" do
+    get edit_password_path("invalid token")
+    assert_redirected_to new_password_path
+
+    follow_redirect!
+    assert_notice "reset link is invalid"
+  end
+
+  test "update" do
+    assert_changes -> { @user.reload.password_digest } do
+      put password_path(@user.password_reset_token), params: { password: "new", password_confirmation: "new" }
+      assert_redirected_to new_session_path
+    end
+
+    follow_redirect!
+    assert_notice "Password has been reset"
+  end
+
+  test "update with non matching passwords" do
+    token = @user.password_reset_token
+    assert_no_changes -> { @user.reload.password_digest } do
+      put password_path(token), params: { password: "no", password_confirmation: "match" }
+      assert_redirected_to edit_password_path(token)
+    end
+
+    follow_redirect!
+    assert_notice "Passwords did not match"
+  end
+
+  private
+    def assert_notice(text)
+      assert_select "div", /#{text}/
+    end
+end

railties/test/generators/authentication_generator_test.rb

@@ -60,6 +60,7 @@ def test_authentication_generator
 
     assert_file "test/models/user_test.rb"
     assert_file "test/fixtures/users.yml"
+    assert_file "test/controllers/passwords_controller_test.rb"
 
     assert_file "test/test_helper.rb" do |content|
       assert_match(/session_test_helper/, content)