Merge pull request rails#54645 from fatkodima/fix-async-aggregations-for-contradictions

Fix async aggregation queries to return promise for contradicted queries

Author: fatkodima

activerecord/lib/active_record/relation/calculations.rb

@@ -497,7 +497,11 @@ def execute_simple_calculation(operation, column_name, distinct) # :nodoc:
         end
 
         query_result = if relation.where_clause.contradiction?
-          ActiveRecord::Result.empty
+          if @async
+            FutureResult.wrap(ActiveRecord::Result.empty)
+          else
+            ActiveRecord::Result.empty
+          end
         else
           skip_query_cache_if_necessary do
             model.with_connection do |c|

activerecord/test/cases/calculations_test.rb

@@ -755,6 +755,13 @@ def test_count_with_block
     assert_equal 4, Account.count { |account| account.credit_limit.modulo(10).zero? }
   end
 
+  def test_count_with_empty_in
+    assert_queries_count(0) do
+      assert_equal 0, Topic.where(id: []).count
+      assert_async_equal 0, Topic.where(id: []).async_count
+    end
+  end
+
   def test_should_sum_expression
     assert_equal 636, Account.sum("2 * credit_limit")
   end