Skip to content

Commit 607ea18

Browse files
committed
Refactor: remove init settings meta reducer, assign settings from localstorage directly to settings initialState
1 parent 4c432c5 commit 607ea18

File tree

4 files changed

+4
-24
lines changed

4 files changed

+4
-24
lines changed
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
export * from './settings.reducer';
22
export * from './settings.facade';
33
export * from './settings.effects';
4-
export * from './meta-reducers/init-settings.reducer';

libs/web/settings/data-access/src/lib/store/meta-reducers/init-settings.reducer.ts

Lines changed: 0 additions & 15 deletions
This file was deleted.

libs/web/settings/data-access/src/lib/store/settings.reducer.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
import { createReducer, on } from '@ngrx/store';
22
import * as SettingsActions from './settings.actions';
3+
import { LocalStorageService } from '../services';
34

45
export const SETTINGS_FEATURE_KEY = 'settings';
56

67
export interface SettingsState {
78
volume: number;
89
}
910

10-
export const initialState: SettingsState = {
11-
volume: 0
12-
};
11+
export const initialState: SettingsState = LocalStorageService.loadInitialState()?.settings ?? {}
1312

1413
export const settingsReducer = createReducer(
1514
initialState,

libs/web/settings/feature/src/lib/settings.module.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,12 @@ import {
66
SETTINGS_FEATURE_KEY,
77
settingsReducer,
88
SettingsEffects,
9-
SettingsFacade,
10-
initSettingsFromLocalStorage
9+
SettingsFacade
1110
} from '@angular-spotify/web/settings/data-access';
1211

1312
@NgModule({
1413
imports: [
15-
StoreModule.forFeature(SETTINGS_FEATURE_KEY, settingsReducer, {
16-
metaReducers: [initSettingsFromLocalStorage]
17-
}),
14+
StoreModule.forFeature(SETTINGS_FEATURE_KEY, settingsReducer),
1815
EffectsModule.forFeature([SettingsEffects])
1916
],
2017
providers: [SettingsFacade]

0 commit comments

Comments
 (0)