Merge pull request trungvose#84 from darxx/more-unit-test

Unit test Example of AuthService login and LoginPayload separation.

Author: trungvose

frontend/src/app/project/auth/auth.service.spec.ts

@@ -0,0 +1,69 @@
+import { AuthService } from './auth.service';
+import { Subject } from 'rxjs';
+import { fakeAsync, tick } from '@angular/core/testing';
+
+describe('AuthService', () => {
+  let service: AuthService;
+
+  const httpClient: any = {
+    get: jasmine.createSpy('get')
+  };
+  const authStore: any = {
+    setLoading: jasmine.createSpy('setLoading').and.callThrough(),
+    update: jasmine.createSpy('update').and.callThrough(),
+    setError: jasmine.createSpy('setError').and.callThrough()
+  };
+
+  beforeEach(() => {
+    service = new AuthService(
+      httpClient,
+      authStore
+    );
+  });
+
+  it('should be able to login', () => {
+    const data = new Subject();
+    httpClient.get.and.returnValue(data);
+    service.login({
+      email: '',
+      password: '',
+    });
+    expect(authStore.setLoading).toHaveBeenCalledWith(true);
+    data.next({
+      id: '',
+      name: '',
+      email: '',
+      avatarUrl: '',
+      createdAt: '',
+      updatedAt: '',
+      issueIds: []
+    });
+    expect(httpClient.get).toHaveBeenCalledWith('/assets/data/auth.json');
+    expect(authStore.update).toHaveBeenCalled();
+  });
+  it('should not be able to login', fakeAsync(() => {
+    const data = new Subject();
+    httpClient.get.and.returnValue(data);
+    service.login({
+      email: '',
+      password: '',
+    });
+    authStore.update.and.callFake(() => {
+      throw new Error('Something bad happened');
+    });
+    expect(authStore.setLoading).toHaveBeenCalledWith(true);
+    authStore.setLoading.calls.reset();
+    data.next({
+      id: '',
+      name: '',
+      email: '',
+      avatarUrl: '',
+      createdAt: '',
+      updatedAt: '',
+      issueIds: []
+    });
+
+    expect(authStore.setLoading).toHaveBeenCalledWith(false);
+    expect(authStore.setError).toHaveBeenCalled();
+  }));
+});

frontend/src/app/project/auth/auth.service.ts

@@ -5,6 +5,7 @@ import { of } from 'rxjs';
 import { catchError, finalize, map } from 'rxjs/operators';
 import { AuthStore } from './auth.store';
 import { environment } from 'src/environments/environment';
+import { LoginPayload } from '@trungk18/project/auth/loginPayload';
 
 @Injectable({ providedIn: 'root' })
 export class AuthService {
@@ -36,11 +37,4 @@ export class AuthService {
   }
 }
 
-export class LoginPayload {
-  email: string;
-  password: string;
-  constructor() {
-    this.email = '[email protected]';
-    this.password = `${new Date().getTime()}`;
-  }
-}
+

frontend/src/app/project/auth/loginPayload.ts

@@ -0,0 +1,8 @@
+export class LoginPayload {
+  email: string;
+  password: string;
+  constructor() {
+    this.email = '[email protected]';
+    this.password = `${new Date().getTime()}`;
+  }
+}

frontend/src/app/project/project.component.ts

@@ -1,6 +1,7 @@
 import { Component, OnInit } from '@angular/core';
 import { ProjectService } from './state/project/project.service';
-import { AuthService, LoginPayload } from './auth/auth.service';
+import { AuthService } from './auth/auth.service';
+import { LoginPayload } from '@trungk18/project/auth/loginPayload';
 
 @Component({
   selector: 'app-project',