Skip to content

Commit 1c3bd35

Browse files
authored
Merge pull request atom#25709 from atom/fix-snapshot-result-macos
Fix `File` -> `Open…` menu on macOS
2 parents f54276d + 6b696d6 commit 1c3bd35

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

script/lib/generate-startup-snapshot.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,10 +322,20 @@ module.exports = function(packagedAppPath) {
322322

323323
const snapshotBinaries = ['v8_context_snapshot.bin', 'snapshot_blob.bin'];
324324
for (let snapshotBinary of snapshotBinaries) {
325-
const destinationPath = path.join(
325+
let destinationPath = path.join(
326326
startupBlobDestinationPath,
327327
snapshotBinary
328328
);
329+
if (
330+
process.platform === 'darwin' &&
331+
snapshotBinary === 'v8_context_snapshot.bin'
332+
) {
333+
// TODO: check if we're building for arm64 and use the arm64 version of the binary
334+
destinationPath = path.join(
335+
startupBlobDestinationPath,
336+
'v8_context_snapshot.x86_64.bin'
337+
);
338+
}
329339
console.log(`Moving generated startup blob into "${destinationPath}"`);
330340
try {
331341
fs.unlinkSync(destinationPath);

0 commit comments

Comments
 (0)