File tree Expand file tree Collapse file tree 2 files changed +1
-2
lines changed
lib/action_dispatch/middleware Expand file tree Collapse file tree 2 files changed +1
-2
lines changed Original file line number Diff line number Diff line change @@ -440,7 +440,6 @@ def handle_options(options)
440
440
441
441
options [ :path ] ||= "/"
442
442
options [ :same_site ] ||= request . cookies_same_site_protection
443
- options [ :same_site ] = false if options [ :same_site ] == :none # TODO: Remove when rack 2.1.0 is out.
444
443
445
444
if options [ :domain ] == :all || options [ :domain ] == "all"
446
445
# If there is a provided tld length then we use it otherwise default domain regexp.
Original file line number Diff line number Diff line change @@ -366,7 +366,7 @@ def test_setting_cookie_with_no_protection
366
366
@request . env [ "action_dispatch.cookies_same_site_protection" ] = :none
367
367
368
368
get :authenticate
369
- assert_cookie_header "user_name=david; path=/" # TODO: append " ; SameSite=None" when rack 2.1.0 is out and bump rack dependency version.
369
+ assert_cookie_header "user_name=david; path=/; SameSite=None"
370
370
assert_equal ( { "user_name" => "david" } , @response . cookies )
371
371
end
372
372
You can’t perform that action at this time.
0 commit comments