Skip to content

Commit 5bd29af

Browse files
committed
Skip cookie comma separation test
Rack updated the RFC they're adhering to when parsing cookies, now no longer including commas. There's still an open question as mentioned in: rails#38420 However, the resilience test is no longer as well needed as it once was and we can move forward separately. If not, this is easily revertible.
1 parent f3eaddb commit 5bd29af

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ GEM
367367
thor
368368
raabro (1.1.6)
369369
racc (1.4.16)
370-
rack (2.1.1)
370+
rack (2.2.1)
371371
rack-cache (1.10.0)
372372
rack (>= 0.4)
373373
rack-protection (2.0.7)
@@ -609,4 +609,4 @@ DEPENDENCIES
609609
websocket-client-simple!
610610

611611
BUNDLED WITH
612-
2.1.2
612+
2.1.4

actionpack/test/dispatch/request_test.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -592,12 +592,6 @@ class RequestCookie < BaseRequestTest
592592
request = stub_request("HTTP_COOKIE" => "_session_id=c84ace84796670c052c6ceb2451fb0f2; is_admin=yes")
593593
assert_equal "c84ace84796670c052c6ceb2451fb0f2", request.cookies["_session_id"], request.cookies.inspect
594594
assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect
595-
596-
# some Nokia phone browsers omit the space after the semicolon separator.
597-
# some developers have grown accustomed to using comma in cookie values.
598-
request = stub_request("HTTP_COOKIE" => "_session_id=c84ace847,96670c052c6ceb2451fb0f2;is_admin=yes")
599-
assert_equal "c84ace847", request.cookies["_session_id"], request.cookies.inspect
600-
assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect
601595
end
602596
end
603597

0 commit comments

Comments
 (0)