Fixed crashing bug in obscured element detection.

Author: jimevans

cpp/iedriver/Element.cpp

@@ -262,7 +262,7 @@ bool Element::IsObscured(LocationInfo* click_location,
       hr = this->element_->QueryInterface<IHTMLDOMNode>(&node);
       if (SUCCEEDED(hr) && node) {
         CComPtr<IHTMLCSSStyleDeclaration> computed_style;
-        hr = window7->getComputedStyle(node, L"", &computed_style);
+        hr = window7->getComputedStyle(node, NULL, &computed_style);
         if (SUCCEEDED(hr) && computed_style) {
           CComBSTR pointer_events_value = L"";
           hr = computed_style->get_pointerEvents(&pointer_events_value);

cpp/iedriverserver/CHANGELOG

@@ -9,6 +9,15 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v3.13.0.3
+=========
+ * Fixed crashing bug in obscured element detection.
+ * Modified to extract IE internal library to IEDriver.tmp first.
+   If the file IEDriver.tmp exists in the destination directory, then use
+   the result of the `GetTempFileName` API, which results in a file named
+   "IEDxxxxx.tmp" where "xxxxx" is a random number.
+ * Added version resources to internal IE driver library.
+
 v3.13.0.2
 =========
  * Modified to prevent keyup actions if key is not already down for IE.

cpp/iedriverserver/IEDriverServer.rc

@@ -50,8 +50,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,13,0,2
- PRODUCTVERSION 3,13,0,2
+ FILEVERSION 3,13,0,3
+ PRODUCTVERSION 3,13,0,3
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -68,12 +68,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Software Freedom Conservancy"
             VALUE "FileDescription", "Command line server for the IE driver"
-            VALUE "FileVersion", "3.13.0.2"
+            VALUE "FileVersion", "3.13.0.3"
             VALUE "InternalName", "IEDriverServer.exe"
-            VALUE "LegalCopyright", "Copyright (C) 2017"
+            VALUE "LegalCopyright", "Copyright (C) 2018"
             VALUE "OriginalFilename", "IEDriverServer.exe"
             VALUE "ProductName", "Selenium WebDriver"
-            VALUE "ProductVersion", "3.13.0.2"
+            VALUE "ProductVersion", "3.13.0.3"
         END
     END
     BLOCK "VarFileInfo"