Skip to content

Commit fbd9df9

Browse files
committed
Modifying build process for C++ components built with Visual Studio.
Breaking out individual build artifacts to use individual build.desc files. Also renaming directory to lower-case to conform to project norms.
1 parent 3e8628b commit fbd9df9

File tree

130 files changed

+74
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

130 files changed

+74
-76
lines changed

WebDriver.sln

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "webdriver-interactions", "c
2828
EndProject
2929
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "webdriver-firefox", "cpp\webdriver-firefox\webdriver-firefox.vcxproj", "{A9D3BB2D-FD1E-43A2-80F6-F8320682323E}"
3030
EndProject
31-
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "IEDriver", "cpp\IEDriver\IEDriver.vcxproj", "{BB72383B-427F-4191-B692-E4345A30E33C}"
31+
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "IEDriver", "cpp\iedriver\IEDriver.vcxproj", "{BB72383B-427F-4191-B692-E4345A30E33C}"
3232
EndProject
3333
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "json-cpp", "third_party\json-cpp\json-cpp.vcxproj", "{320F3BBE-8223-4E7F-ABEE-18D3BD57B1FD}"
3434
EndProject
@@ -70,7 +70,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "webdriver-firefox-previous"
7070
EndProject
7171
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WebDriver.Safari.Tests", "dotnet\test\safari\WebDriver.Safari.Tests.csproj", "{92551430-7C30-421B-A81E-0B08163AC59C}"
7272
EndProject
73-
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "IEDriverServer", "cpp\IEDriverServer\IEDriverServer.vcxproj", "{08C3286F-F132-44EC-80F0-2DF30D87A5D3}"
73+
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "IEDriverServer", "cpp\iedriverserver\IEDriverServer.vcxproj", "{08C3286F-F132-44EC-80F0-2DF30D87A5D3}"
7474
EndProject
7575
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WebDriver.PhantomJS.Tests", "dotnet\test\phantomjs\WebDriver.PhantomJS.Tests.csproj", "{2329720E-A694-4A6F-B4E6-EDEA911298E0}"
7676
EndProject

cpp/build.desc

-67
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,3 @@
1-
visualc_library(name = "firefox_dll",
2-
platform = "Win32",
3-
project = "webdriver-firefox/webdriver-firefox.vcxproj",
4-
file_deps = "third_party/gecko-2/win32",
5-
out = "Win32/Release/webdriver-firefox.dll"
6-
)
7-
8-
visualc_library(name = "firefoxprevious_esr_dll",
9-
platform = "Win32",
10-
project = "webdriver-firefox/webdriver-firefox-esr-previous.vcxproj",
11-
file_deps = "third_party/gecko-10/win32",
12-
out = "Win32/Release/webdriver-firefox-esr-previous.dll"
13-
)
14-
15-
visualc_library(name = "firefoxlatest_esr_dll",
16-
platform = "Win32",
17-
project = "webdriver-firefox/webdriver-firefox-esr-latest.vcxproj",
18-
file_deps = "third_party/gecko-17/win32",
19-
out = "Win32/Release/webdriver-firefox-esr-latest.dll"
20-
)
21-
22-
visualc_library(name = "firefoxprevious_dll",
23-
platform = "Win32",
24-
project = "webdriver-firefox/webdriver-firefox-previous.vcxproj",
25-
file_deps = "third_party/gecko-22/win32",
26-
out = "Win32/Release/webdriver-firefox-previous.dll"
27-
)
28-
29-
visualc_library(name = "firefoxlatest_dll",
30-
platform = "Win32",
31-
project = "webdriver-firefox/webdriver-firefox-latest.vcxproj",
32-
file_deps = "third_party/gecko-23/win32",
33-
out = "Win32/Release/webdriver-firefox-latest.dll"
34-
)
35-
361
mozilla_xpt(name = "native_events_xpt",
372
srcs = [ "webdriver-firefox/nsINativeEvents.idl" ])
383

@@ -144,35 +109,3 @@ visualc_library(name = "imehandler_dll",
144109
project = "imehandler/imehandler.vcxproj",
145110
out = "Win32/Release/imehandler.dll"
146111
)
147-
148-
visualc_release(name = "ie_win32_exe",
149-
deps = [
150-
"//javascript/ie-driver:atoms",
151-
":ie_result_type_cpp",
152-
":sizzle"
153-
],
154-
platform = "Win32",
155-
project = "IEDriverServer/IEDriverServer.vcxproj",
156-
desc = "InternetExplorerDriver standalone server for 32-bit IE",
157-
out = "Win32/Release/IEDriverServer.exe"
158-
)
159-
160-
visualc_release(name = "ie_x64_exe",
161-
deps = [
162-
"//javascript/ie-driver:atoms",
163-
":ie_result_type_cpp",
164-
":sizzle"
165-
],
166-
platform = "x64",
167-
project = "IEDriverServer/IEDriverServer.vcxproj",
168-
desc = "InternetExplorerDriver standalone server for 64-bit IE",
169-
out = "x64/Release/IEDriverServer.exe"
170-
)
171-
172-
rake_task(name = "sizzle",
173-
task_name = "sizzle_header",
174-
out = "cpp/IEDriver/Generated/sizzle.h")
175-
176-
rake_task(name = "ie_result_type_cpp",
177-
task_name = "ie_result_type_cpp",
178-
out = "cpp/IEDriver/Generated/IEReturnTypes.h")
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

cpp/iedriverserver/build.desc

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
visualc_release(name = "win32",
2+
deps = [
3+
"//javascript/ie-driver:atoms",
4+
":ie_result_type_cpp",
5+
":sizzle"
6+
],
7+
platform = "Win32",
8+
project = "IEDriverServer.vcxproj",
9+
desc = "InternetExplorerDriver standalone server for 32-bit IE",
10+
out = "Win32/Release/IEDriverServer.exe"
11+
)
12+
13+
visualc_release(name = "x64",
14+
deps = [
15+
"//javascript/ie-driver:atoms",
16+
":ie_result_type_cpp",
17+
":sizzle"
18+
],
19+
platform = "x64",
20+
project = "IEDriverServer.vcxproj",
21+
desc = "InternetExplorerDriver standalone server for 64-bit IE",
22+
out = "x64/Release/IEDriverServer.exe"
23+
)
24+
25+
rake_task(name = "sizzle",
26+
task_name = "sizzle_header",
27+
out = "cpp/IEDriver/Generated/sizzle.h")
28+
29+
rake_task(name = "ie_result_type_cpp",
30+
task_name = "ie_result_type_cpp",
31+
out = "cpp/IEDriver/Generated/IEReturnTypes.h")
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

cpp/webdriver-firefox/build.desc

+34
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
visualc_library(name = "firefox",
2+
platform = "Win32",
3+
project = "webdriver-firefox.vcxproj",
4+
file_deps = "third_party/gecko-2/win32",
5+
out = "Win32/Release/webdriver-firefox.dll"
6+
)
7+
8+
visualc_library(name = "previous_esr",
9+
platform = "Win32",
10+
project = "webdriver-firefox-esr-previous.vcxproj",
11+
file_deps = "third_party/gecko-10/win32",
12+
out = "Win32/Release/webdriver-firefox-esr-previous.dll"
13+
)
14+
15+
visualc_library(name = "latest_esr",
16+
platform = "Win32",
17+
project = "webdriver-firefox-esr-latest.vcxproj",
18+
file_deps = "third_party/gecko-17/win32",
19+
out = "Win32/Release/webdriver-firefox-esr-latest.dll"
20+
)
21+
22+
visualc_library(name = "previous",
23+
platform = "Win32",
24+
project = "webdriver-firefox-previous.vcxproj",
25+
file_deps = "third_party/gecko-22/win32",
26+
out = "Win32/Release/webdriver-firefox-previous.dll"
27+
)
28+
29+
visualc_library(name = "latest",
30+
platform = "Win32",
31+
project = "webdriver-firefox-latest.vcxproj",
32+
file_deps = "third_party/gecko-23/win32",
33+
out = "Win32/Release/webdriver-firefox-latest.dll"
34+
)

java/client/src/org/openqa/selenium/ie/build.desc

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
java_library(name = "ie",
33
srcs = [ "*.java" ],
44
deps = [
5-
"//cpp:sizzle",
5+
"//cpp/iedriverserver:sizzle",
66
"//java/client/src/org/openqa/selenium/browserlaunchers:windows_proxy_manager",
77
"//java/client/src/org/openqa/selenium/net",
88
"//java/client/src/org/openqa/selenium/remote",

javascript/firefox-driver/build.desc

+5-5
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ mozilla_extension(name = "webdriver",
4848
"//cpp:native_ime_xpt",
4949
],
5050
resources = [
51-
{ "//cpp:firefox_dll" : "platform/WINNT_x86-msvc/components/webdriver-firefox.dll" },
52-
{ "//cpp:firefoxprevious_esr_dll" : "platform/WINNT_x86-msvc/components/webdriver-firefox-esr-previous.dll" },
53-
{ "//cpp:firefoxlatest_esr_dll" : "platform/WINNT_x86-msvc/components/webdriver-firefox-esr-latest.dll" },
54-
{ "//cpp:firefoxprevious_dll" : "platform/WINNT_x86-msvc/components/webdriver-firefox-previous.dll" },
55-
{ "//cpp:firefoxlatest_dll" : "platform/WINNT_x86-msvc/components/webdriver-firefox-latest.dll" },
51+
{ "//cpp/webdriver-firefox:firefox" : "platform/WINNT_x86-msvc/components/webdriver-firefox.dll" },
52+
{ "//cpp/webdriver-firefox:previous_esr" : "platform/WINNT_x86-msvc/components/webdriver-firefox-esr-previous.dll" },
53+
{ "//cpp/webdriver-firefox:latest_esr" : "platform/WINNT_x86-msvc/components/webdriver-firefox-esr-latest.dll" },
54+
{ "//cpp/webdriver-firefox:previous" : "platform/WINNT_x86-msvc/components/webdriver-firefox-previous.dll" },
55+
{ "//cpp/webdriver-firefox:latest" : "platform/WINNT_x86-msvc/components/webdriver-firefox-latest.dll" },
5656
{ "//cpp:imehandler_dll" : "platform/WINNT_x86-msvc/components/imehandler.dll" },
5757
{ "//cpp:webdriver_firefox_ff3" : "platform/Linux_x86-gcc3/components/libwebdriver-firefox-ff3.so" },
5858
{ "//cpp:webdriver_firefox_esr_previous" : "platform/Linux_x86-gcc3/components/libwebdriver-firefox-esr-previous.so" },

rake-tasks/crazy_fun/mappings/visualstudio.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,7 @@ def get_version(dir)
648648
module CrazyFunVisualC
649649
class VisualCLibrary < Tasks
650650
def handle(fun, dir, args)
651-
full_path = File.join("build", dir, args[:out])
651+
full_path = File.join("build/cpp", args[:out])
652652
desc_path = full_path.gsub("/", Platform.dir_separator)
653653
desc "Build #{desc_path}"
654654

0 commit comments

Comments
 (0)