Skip to content

Commit a07f064

Browse files
Merge pull request opencv#18332 from TolyaTalamanov:at/wrap-GIn-GOut
[G-API] Wrap GIn & GOut * Wrap GIn & GOut into python * Remove extra brackets * Use reinterpret_cast
1 parent ea4b491 commit a07f064

File tree

6 files changed

+48
-4
lines changed

6 files changed

+48
-4
lines changed

modules/gapi/include/opencv2/gapi/gcomputation.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ class GAPI_EXPORTS_W GComputation
161161
*
162162
* @sa @ref gapi_data_objects
163163
*/
164-
GComputation(GProtoInputArgs &&ins,
165-
GProtoOutputArgs &&outs); // Arg-to-arg overload
164+
GAPI_WRAP GComputation(GProtoInputArgs &&ins,
165+
GProtoOutputArgs &&outs); // Arg-to-arg overload
166166

167167
// 2. Syntax sugar and compatibility overloads
168168
/**

modules/gapi/include/opencv2/gapi/gproto.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ template<class Tag>
5757
struct GIOProtoArgs
5858
{
5959
public:
60+
// NB: Used by python wrapper
61+
GIOProtoArgs() = default;
6062
explicit GIOProtoArgs(const GProtoArgs& args) : m_args(args) {}
6163
explicit GIOProtoArgs(GProtoArgs &&args) : m_args(std::move(args)) {}
6264

modules/gapi/misc/python/pyopencv_gapi.hpp

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,35 @@ PyObject* pyopencv_from(const std::vector<GCompileArg>& value)
1111
{
1212
return pyopencv_from_generic_vec(value);
1313
}
14+
15+
template <typename T>
16+
static PyObject* extract_proto_args(PyObject* py_args, PyObject* kw)
17+
{
18+
using namespace cv;
19+
20+
GProtoArgs args;
21+
Py_ssize_t size = PyTuple_Size(py_args);
22+
for (int i = 0; i < size; ++i) {
23+
PyObject* item = PyTuple_GetItem(py_args, i);
24+
if (PyObject_TypeCheck(item, reinterpret_cast<PyTypeObject*>(pyopencv_GScalar_TypePtr))) {
25+
args.emplace_back(reinterpret_cast<pyopencv_GScalar_t*>(item)->v);
26+
} else if (PyObject_TypeCheck(item, reinterpret_cast<PyTypeObject*>(pyopencv_GMat_TypePtr))) {
27+
args.emplace_back(reinterpret_cast<pyopencv_GMat_t*>(item)->v);
28+
} else {
29+
PyErr_SetString(PyExc_TypeError, "cv.GIn() supports only cv.GMat and cv.GScalar");
30+
return NULL;
31+
}
32+
}
33+
34+
return pyopencv_from<T>(T{std::move(args)});
35+
}
36+
37+
static PyObject* pyopencv_cv_GIn(PyObject* , PyObject* py_args, PyObject* kw)
38+
{
39+
return extract_proto_args<GProtoInputArgs>(py_args, kw);
40+
}
41+
42+
static PyObject* pyopencv_cv_GOut(PyObject* , PyObject* py_args, PyObject* kw)
43+
{
44+
return extract_proto_args<GProtoOutputArgs>(py_args, kw);
45+
}

modules/gapi/misc/python/shadow_gapi.hpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
namespace cv
55
{
66
GAPI_EXPORTS_W GCompileArgs compile_args(gapi::GKernelPackage pkg);
7+
class GAPI_EXPORTS_W_SIMPLE GProtoArg { };
8+
class GAPI_EXPORTS_W_SIMPLE GProtoInputArgs { };
9+
class GAPI_EXPORTS_W_SIMPLE GProtoOutputArgs { };
10+
11+
using GProtoInputArgs = GIOProtoArgs<In_Tag>;
12+
using GProtoOutputArgs = GIOProtoArgs<Out_Tag>;
713
} // namespace cv

modules/gapi/misc/python/test/test_gapi_core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_add(self):
3030
g_in1 = cv.GMat()
3131
g_in2 = cv.GMat()
3232
g_out = cv.gapi.add(g_in1, g_in2)
33-
comp = cv.GComputation(g_in1, g_in2, g_out)
33+
comp = cv.GComputation(cv.GIn(g_in1, g_in2), cv.GOut(g_out))
3434

3535
for pkg in pkgs:
3636
actual = comp.apply(in1, in2, args=cv.compile_args(pkg))

modules/python/src2/cv2.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1891,7 +1891,6 @@ static int convert_to_char(PyObject *o, char *dst, const ArgInfo& info)
18911891

18921892

18931893
#include "pyopencv_generated_enums.h"
1894-
#include "pyopencv_custom_headers.h"
18951894

18961895
#ifdef CVPY_DYNAMIC_INIT
18971896
#define CVPY_TYPE(NAME, STORAGE, SNAME, _1, _2) CVPY_TYPE_DECLARE_DYNAMIC(NAME, STORAGE, SNAME)
@@ -1900,6 +1899,7 @@ static int convert_to_char(PyObject *o, char *dst, const ArgInfo& info)
19001899
#endif
19011900
#include "pyopencv_generated_types.h"
19021901
#undef CVPY_TYPE
1902+
#include "pyopencv_custom_headers.h"
19031903

19041904
#include "pyopencv_generated_types_content.h"
19051905
#include "pyopencv_generated_funcs.h"
@@ -1915,6 +1915,10 @@ static PyMethodDef special_methods[] = {
19151915
#ifdef HAVE_OPENCV_DNN
19161916
{"dnn_registerLayer", CV_PY_FN_WITH_KW(pyopencv_cv_dnn_registerLayer), "registerLayer(type, class) -> None"},
19171917
{"dnn_unregisterLayer", CV_PY_FN_WITH_KW(pyopencv_cv_dnn_unregisterLayer), "unregisterLayer(type) -> None"},
1918+
#endif
1919+
#ifdef HAVE_OPENCV_GAPI
1920+
{"GIn", CV_PY_FN_WITH_KW(pyopencv_cv_GIn), "GIn(...) -> GInputProtoArgs"},
1921+
{"GOut", CV_PY_FN_WITH_KW(pyopencv_cv_GOut), "GOut(...) -> GOutputProtoArgs"},
19181922
#endif
19191923
{NULL, NULL},
19201924
};

0 commit comments

Comments
 (0)