Added test for backwards compatibilty support

Author: mitsuhiko

flask/module.py

@@ -23,9 +23,8 @@ def _register(state):
         state.app.modules[module.name] = module
         path = module.static_path
         # XXX: backwards compatibility.  This will go away in 1.0
-        if path is None and module._backwards_compat_static_path:
-            path = module.static_path
-            if path == app.static_path:
+        if module._backwards_compat_static_path:
+            if path == state.app.static_path:
                 return
             from warnings import warn
             warn(DeprecationWarning('With Flask 0.7 the static folder '
@@ -35,7 +34,7 @@ def _register(state):
                 'Pass ``static_path=\'static\'`` to the Module '
                 'constructor if you want to use static folders.\n'
                 'This backwards compatibility support will go away in '
-                'Flask 1.0'), stacklevel=3)
+                'Flask 1.0'), stacklevel=2)
         if path is None:
             return
         path = '/' + os.path.basename(path)

tests/flask_tests.py

@@ -828,6 +828,15 @@ def test_safe_access(self):
             else:
                 assert 0, 'expected exception'
 
+    def test_static_path_backwards_compat(self):
+        with catch_warnings() as captured:
+            from modulecompat import app
+            rv = app.test_client().get('/test/static/hello.txt')
+            assert rv.data.strip() == 'Hello World!'
+
+            # the warning for missing static_path
+            assert len(captured) == 1
+
 
 class SendfileTestCase(unittest.TestCase):
 

tests/modulecompat/__init__.py

@@ -0,0 +1,6 @@
+from flask import Flask
+
+
+app = Flask(__name__)
+from modulecompat.test import mod
+app.register_module(mod, url_prefix='/test')

tests/modulecompat/test/__init__.py

@@ -0,0 +1,4 @@
+from flask import Module
+
+
+mod = Module(__name__)

tests/modulecompat/test/static/hello.txt

@@ -0,0 +1 @@
+Hello World!