Skip to content

Commit fb181ff

Browse files
committed
Hide progress when exception occurs
1 parent c859b80 commit fb181ff

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

app/src/main/java/com/github/mobile/ui/ItemListFragment.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ public void onItemClick(AdapterView<?> parent, View view,
139139
@Override
140140
public boolean onItemLongClick(AdapterView<?> parent, View view,
141141
int position, long id) {
142-
return onListItemLongClick((ListView) parent, view, position, id);
142+
return onListItemLongClick((ListView) parent, view, position,
143+
id);
143144
}
144145
});
145146
progressBar = (ProgressBar) view.findViewById(id.pb_loading);
@@ -198,7 +199,8 @@ private void refresh(final Bundle args) {
198199
if (!isUsable())
199200
return;
200201

201-
getSherlockActivity().setSupportProgressBarIndeterminateVisibility(true);
202+
getSherlockActivity()
203+
.setSupportProgressBarIndeterminateVisibility(true);
202204
getLoaderManager().restartLoader(0, args, this);
203205
}
204206

@@ -211,6 +213,11 @@ private void refresh(final Bundle args) {
211213
protected abstract int getErrorMessage(Exception exception);
212214

213215
public void onLoadFinished(Loader<List<E>> loader, List<E> items) {
216+
if (!isUsable())
217+
return;
218+
219+
getSherlockActivity().setSupportProgressBarIndeterminateVisibility(
220+
false);
214221
Exception exception = getException(loader);
215222
if (exception != null) {
216223
showError(exception, getErrorMessage(exception));
@@ -221,8 +228,6 @@ public void onLoadFinished(Loader<List<E>> loader, List<E> items) {
221228
this.items = items;
222229
getListAdapter().getWrappedAdapter().setItems(items.toArray());
223230
showList();
224-
225-
getSherlockActivity().setSupportProgressBarIndeterminateVisibility(false);
226231
}
227232

228233
/**

0 commit comments

Comments
 (0)