Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wfleming/codeclimate-shellcheck
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codeclimate-community/codeclimate-shellcheck
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 0 files changed
  • 2 contributors

Commits on Sep 12, 2019

  1. Favor volume mounting over file system mounting

    We were running into some issues getting this to build on CI. While the
    image built fine locally, on CI, we'd hit an error at the step in the
    docker file `Release.plan` where we tried to `ADD
    .local/bin/codeclimate-shellcheck /home/app/bin/engine`. Will did some
    digging and was able to determine that we likely needed to volume mount
    instead.
    
    Co-authored-by: Will Fleming <[email protected]>
    larkinscott and wfleming committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    b33b96b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from codeclimate-community/sl+wf/docker-changes

    Favor volume mounting over file system mounting
    larkinscott authored Sep 12, 2019
    Configuration menu
    Copy the full SHA
    e06e006 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Configuration menu
    Copy the full SHA
    ec380d8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from codeclimate-community/revert-1-sl+wf/docke…

    …r-changes
    
    Revert "Favor volume mounting over file system mounting"
    larkinscott authored Sep 13, 2019
    Configuration menu
    Copy the full SHA
    143fb27 View commit details
    Browse the repository at this point in the history
Loading